Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CES-106] Delete unused folders and Core legacy folder renamed #1210

Merged
merged 8 commits into from
Sep 30, 2024

Conversation

Krusty93
Copy link
Contributor

List of changes

Delete old unused folders:

  • .template_app
  • .template_common

Moved last files into legacy-apim folder
Renamed Core legacy state file

Motivation and context

We've done with refactoring 🍾

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

How to apply

After PR is approved

  1. run deploy pipeline from Azure DevOps io-platform-iac-projects
  2. select PR branch
  3. wait for approval

@gunzip
Copy link
Contributor

gunzip commented Sep 30, 2024

why is it called legacy-apim?

what about .utils folder?

@Krusty93
Copy link
Contributor Author

Krusty93 commented Sep 30, 2024

why is it called legacy-apim?

what about .utils folder?

it's not a utility as it will be dismissed (hopefully) before next spring. The only reason why this config exists is because moving the two API groups in it is too risky , and since both of them will be deleted soon we took the decision to keep them as they are.

But no files should be moved here anymore

Copy link

Copy link

📖 Terraform Plan ('src/legacy-apim/prod') - success

Terraform Plan
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # azurerm_api_management_named_value.io_fn3_eucovidcert_url_alt_v2 will be updated in-place
  ~ resource "azurerm_api_management_named_value" "io_fn3_eucovidcert_url_alt_v2" {
        id                  = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-internal/providers/Microsoft.ApiManagement/service/io-p-apim-v2-api/namedValues/io-fn3-eucovidcert-url-alt"
        name                = "io-fn3-eucovidcert-url-alt"
        tags                = []
        # (5 unchanged attributes hidden)
    }

  # azurerm_api_management_named_value.io_fn3_services_url_v2 will be updated in-place
  ~ resource "azurerm_api_management_named_value" "io_fn3_services_url_v2" {
        id                  = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-internal/providers/Microsoft.ApiManagement/service/io-p-apim-v2-api/namedValues/io-fn3-services-url"
        name                = "io-fn3-services-url"
        tags                = []
        # (5 unchanged attributes hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Copy link

📖 Terraform Plan ('src/core/prod') - success

Terraform Plan
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.container_registry.azurerm_container_registry.this will be updated in-place
  ~ resource "azurerm_container_registry" "this" {
        id                            = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-container-registry-rg/providers/Microsoft.ContainerRegistry/registries/iopcommonacr"
        name                          = "iopcommonacr"
        tags                          = {
            "CostCenter"  = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"   = "Terraform"
            "Environment" = "Prod"
            "Owner"       = "IO"
            "Source"      = "https://github.com/pagopa/io-infra/blob/main/src/core/prod"
        }
        # (16 unchanged attributes hidden)
    }

  # module.azdoa_weu.module.azdoa_li_infra.azurerm_linux_virtual_machine_scale_set.this will be updated in-place
  ~ resource "azurerm_linux_virtual_machine_scale_set" "this" {
        id                                                = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-azdoa-rg/providers/Microsoft.Compute/virtualMachineScaleSets/io-p-azdoa-vmss-li-infra"
      ~ instances                                         = 1 -> 0
        name                                              = "io-p-azdoa-vmss-li-infra"
        tags                                              = {
            "__AzureDevOpsElasticPool"          = "io-prod-linux"
            "__AzureDevOpsElasticPoolTimeStamp" = "9/30/2024 1:42:00 PM"
        }
        # (24 unchanged attributes hidden)

        # (6 unchanged blocks hidden)
    }

  # module.azdoa_weu.module.azdoa_li_infra.tls_private_key.this_key will be updated in-place
  ~ resource "tls_private_key" "this_key" {
        id                            = "14531208910692e84fa5c5e2c5c127aa067bccf8"
        # (10 unchanged attributes hidden)
    }

  # module.azdoa_weu.module.azdoa_loadtest_li.azurerm_linux_virtual_machine_scale_set.this will be updated in-place
  ~ resource "azurerm_linux_virtual_machine_scale_set" "this" {
        id                                                = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-azdoa-rg/providers/Microsoft.Compute/virtualMachineScaleSets/io-p-azdoa-vmss-loadtest-li"
        name                                              = "io-p-azdoa-vmss-loadtest-li"
        tags                                              = {
            "__AzureDevOpsElasticPool"          = "io-prod-loadtest-linux"
            "__AzureDevOpsElasticPoolTimeStamp" = "2/3/2024 10:56:53 AM"
        }
        # (25 unchanged attributes hidden)

        # (6 unchanged blocks hidden)
    }

  # module.azdoa_weu.module.azdoa_loadtest_li.tls_private_key.this_key will be updated in-place
  ~ resource "tls_private_key" "this_key" {
        id                            = "8feb8c752be6808a3393f79ad8fd66c378e54420"
        # (10 unchanged attributes hidden)
    }

  # module.vpn_weu.module.dns_forwarder.azurerm_container_group.this will be updated in-place
  ~ resource "azurerm_container_group" "this" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.ContainerInstance/containerGroups/io-p-dns-forwarder"
        name                        = "io-p-dns-forwarder"
        tags                        = {
            "CostCenter"  = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"   = "Terraform"
            "Environment" = "Prod"
            "Owner"       = "IO"
            "Source"      = "https://github.com/pagopa/io-infra/blob/main/src/core/prod"
        }
        # (11 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 6 to change, 0 to destroy.

Warning: Deprecated attribute

  on ../_modules/vpn/main.tf line 27, in module "vpn":
  27:       aad_audience          = data.azuread_application.vpn_app.application_id

The attribute "application_id" is deprecated. Refer to the provider
documentation for details.

(and one more similar warning elsewhere)

Warning: Argument is deprecated

  with module.azdoa_weu.module.azdoa_snet.azurerm_subnet.this,
  on .terraform/modules/azdoa_weu.azdoa_snet/subnet/main.tf line 23, in resource "azurerm_subnet" "this":
  23:   private_endpoint_network_policies_enabled     = var.private_endpoint_network_policies_enabled

`private_endpoint_network_policies_enabled` will be removed in favour of the
property `private_endpoint_network_policies` in version 4.0 of the AzureRM
Provider

(and 14 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Copy link

📖 Terraform Plan ('src/common/prod') - success

Terraform Plan
module.application_gateway_weu.data.azurerm_linux_web_app.appservice_continua: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.session_manager: Still reading... [10s elapsed]
data.azurerm_linux_function_app.services_app_backend_function_app: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.appservice_devportal_be: Still reading... [10s elapsed]
data.azurerm_linux_function_app.lollipop_function: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.cms_backoffice_app_itn: Still reading... [10s elapsed]
data.azurerm_linux_function_app.function_cgn: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.fims_op_app: Still reading... [10s elapsed]
data.azurerm_linux_function_app.wallet_user: Still reading... [10s elapsed]
data.azurerm_linux_function_app.function_assets_cdn: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.appservice_continua: Still reading... [20s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.session_manager: Still reading... [20s elapsed]
data.azurerm_linux_function_app.services_app_backend_function_app: Still reading... [20s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.appservice_devportal_be: Still reading... [20s elapsed]
data.azurerm_linux_function_app.lollipop_function: Still reading... [20s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.cms_backoffice_app_itn: Still reading... [20s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.fims_op_app: Still reading... [20s elapsed]
data.azurerm_linux_function_app.wallet_user: Still reading... [20s elapsed]
data.azurerm_linux_function_app.eucovidcert: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.appservice_selfcare_be: Still reading... [10s elapsed]
data.azurerm_linux_web_app.firmaconio_selfcare_web_app: Still reading... [10s elapsed]
data.azurerm_linux_function_app.io_sign_user: Still reading... [10s elapsed]
data.azurerm_linux_function_app.function_app[0]: Still reading... [10s elapsed]
data.azurerm_linux_function_app.function_app[1]: Still reading... [10s elapsed]
data.azurerm_linux_function_app.eucovidcert: Still reading... [20s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.appservice_selfcare_be: Still reading... [20s elapsed]
data.azurerm_linux_web_app.firmaconio_selfcare_web_app: Still reading... [20s elapsed]
data.azurerm_linux_function_app.io_sign_user: Still reading... [20s elapsed]
data.azurerm_linux_function_app.function_app[1]: Still reading... [20s elapsed]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.apim_weu.azurerm_api_management_subscription.pn_lc_subscription_v2 will be updated in-place
  ~ resource "azurerm_api_management_subscription" "pn_lc_subscription_v2" {
        id                  = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-internal/providers/Microsoft.ApiManagement/service/io-p-apim-v2-api/subscriptions/4ab4fd2e-138b-4d2a-98af-0ca4bb23680e"
        # (10 unchanged attributes hidden)
    }

  # module.apim_weu.azurerm_api_management_user.pn_user_v2 will be updated in-place
  ~ resource "azurerm_api_management_user" "pn_user_v2" {
        id                  = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-internal/providers/Microsoft.ApiManagement/service/io-p-apim-v2-api/users/pnapimuser"
        # (7 unchanged attributes hidden)
    }

  # module.application_gateway_weu.azurerm_web_application_firewall_policy.api_app will be updated in-place
  ~ resource "azurerm_web_application_firewall_policy" "api_app" {
        id                  = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-external/providers/Microsoft.Network/applicationGatewayWebApplicationFirewallPolicies/io-p-waf-appgateway-api-app-policy"
        name                = "io-p-waf-appgateway-api-app-policy"
        tags                = {
            "CostCenter"  = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"   = "Terraform"
            "Environment" = "Prod"
            "Owner"       = "IO"
            "Source"      = "https://github.com/pagopa/io-infra"
        }
        # (4 unchanged attributes hidden)

      ~ policy_settings {
          ~ request_body_inspect_limit_in_kb          = 0 -> 128
            # (6 unchanged attributes hidden)
        }

        # (1 unchanged block hidden)
    }

  # module.cosmos_api_weu.azurerm_cosmosdb_account.this will be updated in-place
  ~ resource "azurerm_cosmosdb_account" "this" {
        id                                       = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-internal/providers/Microsoft.DocumentDB/databaseAccounts/io-p-cosmos-api"
        name                                     = "io-p-cosmos-api"
        tags                                     = {
            "CostCenter"  = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"   = "Terraform"
            "Environment" = "Prod"
            "Owner"       = "IO"
            "Source"      = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
        }
        # (35 unchanged attributes hidden)

        # (13 unchanged blocks hidden)
    }

  # module.github_runner_itn.azurerm_container_app_environment.github_runner will be updated in-place
  ~ resource "azurerm_container_app_environment" "github_runner" {
        id                               = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-github-runner-rg-01/providers/Microsoft.App/managedEnvironments/io-p-itn-github-runner-cae-01"
        name                             = "io-p-itn-github-runner-cae-01"
        tags                             = {
            "CostCenter"  = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"   = "Terraform"
            "Environment" = "Prod"
            "Owner"       = "IO"
            "Source"      = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
        }
        # (12 unchanged attributes hidden)
    }

  # module.monitoring_weu.azurerm_application_insights.appi will be updated in-place
  ~ resource "azurerm_application_insights" "appi" {
        id                                    = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Insights/components/io-p-ai-common"
        name                                  = "io-p-ai-common"
        tags                                  = {
            "CostCenter"  = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"   = "Terraform"
            "Environment" = "Prod"
            "Owner"       = "IO"
            "Source"      = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
        }
        # (16 unchanged attributes hidden)
    }

  # module.monitoring_weu.azurerm_log_analytics_workspace.log will be updated in-place
  ~ resource "azurerm_log_analytics_workspace" "log" {
        id                                      = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.OperationalInsights/workspaces/io-p-law-common"
        name                                    = "io-p-law-common"
        tags                                    = {
            "CostCenter"  = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"   = "Terraform"
            "Environment" = "Prod"
            "Owner"       = "IO"
            "Source"      = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
        }
        # (14 unchanged attributes hidden)
    }

  # module.redis_weu.azurerm_redis_cache.common will be updated in-place
  ~ resource "azurerm_redis_cache" "common" {
        id                            = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Cache/redis/io-p-redis-common"
        name                          = "io-p-redis-common"
        tags                          = {
            "CostCenter"  = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"   = "Terraform"
            "Environment" = "Prod"
            "Owner"       = "IO"
            "Source"      = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
        }
        # (24 unchanged attributes hidden)

        # (6 unchanged blocks hidden)
    }

  # module.apim_weu.module.apim_v2.azurerm_api_management.this will be updated in-place
  ~ resource "azurerm_api_management" "this" {
        id                            = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-internal/providers/Microsoft.ApiManagement/service/io-p-apim-v2-api"
        name                          = "io-p-apim-v2-api"
        tags                          = {
            "CostCenter"  = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"   = "Terraform"
            "Environment" = "Prod"
            "Owner"       = "IO"
            "Source"      = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
        }
        # (21 unchanged attributes hidden)

        # (9 unchanged blocks hidden)
    }

  # module.app_backend_li_weu.module.appservice_app_backend.azurerm_linux_web_app.this will be updated in-place
  ~ resource "azurerm_linux_web_app" "this" {
        id                                             = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-linux/providers/Microsoft.Web/sites/io-p-app-appbackendli"
        name                                           = "io-p-app-appbackendli"
        tags                                           = {
            "CostCenter"                                     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"                                      = "Terraform"
            "Environment"                                    = "Prod"
            "Owner"                                          = "IO"
            "Source"                                         = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
        }
        # (22 unchanged attributes hidden)

      ~ site_config {
            # (25 unchanged attributes hidden)

          - ip_restriction {
              - action                    = "Allow" -> null
              - headers                   = [] -> null
              - name                      = "temp-rule" -> null
              - priority                  = 300 -> null
              - virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/virtualNetworks/io-p-itn-common-vnet-01/subnets/io-p-itn-citizen-auth-fast-login-snet-01" -> null
            }

            # (19 unchanged blocks hidden)
        }

        # (1 unchanged block hidden)
    }

  # module.app_backend_li_weu.module.appservice_app_backend_slot_staging.azurerm_linux_web_app_slot.this will be updated in-place
  ~ resource "azurerm_linux_web_app_slot" "this" {
        id                                             = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-linux/providers/Microsoft.Web/sites/io-p-app-appbackendli/slots/staging"
        name                                           = "staging"
        tags                                           = {
            "CostCenter"  = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"   = "Terraform"
            "Environment" = "Prod"
            "Owner"       = "IO"
            "Source"      = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
        }
        # (21 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.app_backend_weu["l1"].module.appservice_app_backend.azurerm_linux_web_app.this will be updated in-place
  ~ resource "azurerm_linux_web_app" "this" {
        id                                             = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-linux/providers/Microsoft.Web/sites/io-p-app-appbackendl1"
        name                                           = "io-p-app-appbackendl1"
        tags                                           = {
            "CostCenter"                                     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"                                      = "Terraform"
            "Environment"                                    = "Prod"
            "Owner"                                          = "IO"
            "Source"                                         = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
        }
        # (22 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.app_backend_weu["l1"].module.appservice_app_backend_slot_staging.azurerm_linux_web_app_slot.this will be updated in-place
  ~ resource "azurerm_linux_web_app_slot" "this" {
        id                                             = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-linux/providers/Microsoft.Web/sites/io-p-app-appbackendl1/slots/staging"
        name                                           = "staging"
        tags                                           = {
            "CostCenter"  = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"   = "Terraform"
            "Environment" = "Prod"
            "Owner"       = "IO"
            "Source"      = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
        }
        # (21 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.app_backend_weu["l2"].module.appservice_app_backend.azurerm_linux_web_app.this will be updated in-place
  ~ resource "azurerm_linux_web_app" "this" {
        id                                             = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-linux/providers/Microsoft.Web/sites/io-p-app-appbackendl2"
        name                                           = "io-p-app-appbackendl2"
        tags                                           = {
            "CostCenter"                                     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"                                      = "Terraform"
            "Environment"                                    = "Prod"
            "Owner"                                          = "IO"
            "Source"                                         = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
        }
        # (22 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.app_backend_weu["l2"].module.appservice_app_backend_slot_staging.azurerm_linux_web_app_slot.this will be updated in-place
  ~ resource "azurerm_linux_web_app_slot" "this" {
        id                                             = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-linux/providers/Microsoft.Web/sites/io-p-app-appbackendl2/slots/staging"
        name                                           = "staging"
        tags                                           = {
            "CostCenter"  = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"   = "Terraform"
            "Environment" = "Prod"
            "Owner"       = "IO"
            "Source"      = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
        }
        # (21 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # module.application_gateway_weu.module.app_gw.azurerm_application_gateway.this will be updated in-place
  ~ resource "azurerm_application_gateway" "this" {
        id                                = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-external/providers/Microsoft.Network/applicationGateways/io-p-appgateway"
        name                              = "io-p-appgateway"
        tags                              = {
            "CostCenter"  = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"   = "Terraform"
            "Environment" = "Prod"
            "Owner"       = "IO"
            "Source"      = "https://github.com/pagopa/io-infra"
        }
        # (7 unchanged attributes hidden)

        # (87 unchanged blocks hidden)
    }

  # module.assets_cdn_weu.module.assets_cdn.azurerm_storage_account.this will be updated in-place
  ~ resource "azurerm_storage_account" "this" {
        id                                = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Storage/storageAccounts/iopstcdnassets"
        name                              = "iopstcdnassets"
        tags                              = {
            "CostCenter"  = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"   = "Terraform"
            "Environment" = "Prod"
            "Owner"       = "IO"
            "Source"      = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
        }
        # (42 unchanged attributes hidden)

        # (4 unchanged blocks hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_authorization_rule.events["import-command.io-fn-elt"] will be updated in-place
  ~ resource "azurerm_eventhub_authorization_rule" "events" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns/eventhubs/import-command/authorizationRules/io-fn-elt"
        name                        = "io-fn-elt"
        # (10 unchanged attributes hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_authorization_rule.events["import-command.ops"] will be updated in-place
  ~ resource "azurerm_eventhub_authorization_rule" "events" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns/eventhubs/import-command/authorizationRules/ops"
        name                        = "ops"
        # (10 unchanged attributes hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_authorization_rule.events["io-cosmosdb-message-status-for-view.io-cdc"] will be updated in-place
  ~ resource "azurerm_eventhub_authorization_rule" "events" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns/eventhubs/io-cosmosdb-message-status-for-view/authorizationRules/io-cdc"
        name                        = "io-cdc"
        # (10 unchanged attributes hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_authorization_rule.events["io-cosmosdb-message-status-for-view.io-messages"] will be updated in-place
  ~ resource "azurerm_eventhub_authorization_rule" "events" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns/eventhubs/io-cosmosdb-message-status-for-view/authorizationRules/io-messages"
        name                        = "io-messages"
        # (10 unchanged attributes hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_authorization_rule.events["io-cosmosdb-message-status.io-cdc"] will be updated in-place
  ~ resource "azurerm_eventhub_authorization_rule" "events" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns/eventhubs/io-cosmosdb-message-status/authorizationRules/io-cdc"
        name                        = "io-cdc"
        # (10 unchanged attributes hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_authorization_rule.events["io-cosmosdb-message-status.io-messages"] will be updated in-place
  ~ resource "azurerm_eventhub_authorization_rule" "events" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns/eventhubs/io-cosmosdb-message-status/authorizationRules/io-messages"
        name                        = "io-messages"
        # (10 unchanged attributes hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_authorization_rule.events["io-cosmosdb-profiles.io-fn-elt"] will be updated in-place
  ~ resource "azurerm_eventhub_authorization_rule" "events" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns/eventhubs/io-cosmosdb-profiles/authorizationRules/io-fn-elt"
        name                        = "io-fn-elt"
        # (10 unchanged attributes hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_authorization_rule.events["io-cosmosdb-profiles.pdnd"] will be updated in-place
  ~ resource "azurerm_eventhub_authorization_rule" "events" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns/eventhubs/io-cosmosdb-profiles/authorizationRules/pdnd"
        name                        = "pdnd"
        # (10 unchanged attributes hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_authorization_rule.events["io-cosmosdb-services.io-fn-elt"] will be updated in-place
  ~ resource "azurerm_eventhub_authorization_rule" "events" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns/eventhubs/io-cosmosdb-services/authorizationRules/io-fn-elt"
        name                        = "io-fn-elt"
        # (10 unchanged attributes hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_authorization_rule.events["io-cosmosdb-services.pdnd"] will be updated in-place
  ~ resource "azurerm_eventhub_authorization_rule" "events" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns/eventhubs/io-cosmosdb-services/authorizationRules/pdnd"
        name                        = "pdnd"
        # (10 unchanged attributes hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_authorization_rule.events["pdnd-io-cosmosdb-message-status.io-fn-elt"] will be updated in-place
  ~ resource "azurerm_eventhub_authorization_rule" "events" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns/eventhubs/pdnd-io-cosmosdb-message-status/authorizationRules/io-fn-elt"
        name                        = "io-fn-elt"
        # (10 unchanged attributes hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_authorization_rule.events["pdnd-io-cosmosdb-message-status.pdnd"] will be updated in-place
  ~ resource "azurerm_eventhub_authorization_rule" "events" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns/eventhubs/pdnd-io-cosmosdb-message-status/authorizationRules/pdnd"
        name                        = "pdnd"
        # (10 unchanged attributes hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_authorization_rule.events["pdnd-io-cosmosdb-messages.io-fn-elt"] will be updated in-place
  ~ resource "azurerm_eventhub_authorization_rule" "events" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns/eventhubs/pdnd-io-cosmosdb-messages/authorizationRules/io-fn-elt"
        name                        = "io-fn-elt"
        # (10 unchanged attributes hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_authorization_rule.events["pdnd-io-cosmosdb-messages.pdnd"] will be updated in-place
  ~ resource "azurerm_eventhub_authorization_rule" "events" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns/eventhubs/pdnd-io-cosmosdb-messages/authorizationRules/pdnd"
        name                        = "pdnd"
        # (10 unchanged attributes hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_authorization_rule.events["pdnd-io-cosmosdb-notification-status.io-fn-elt"] will be updated in-place
  ~ resource "azurerm_eventhub_authorization_rule" "events" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns/eventhubs/pdnd-io-cosmosdb-notification-status/authorizationRules/io-fn-elt"
        name                        = "io-fn-elt"
        # (10 unchanged attributes hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_authorization_rule.events["pdnd-io-cosmosdb-notification-status.pdnd"] will be updated in-place
  ~ resource "azurerm_eventhub_authorization_rule" "events" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns/eventhubs/pdnd-io-cosmosdb-notification-status/authorizationRules/pdnd"
        name                        = "pdnd"
        # (10 unchanged attributes hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_authorization_rule.events["pdnd-io-cosmosdb-service-preferences.io-fn-elt"] will be updated in-place
  ~ resource "azurerm_eventhub_authorization_rule" "events" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns/eventhubs/pdnd-io-cosmosdb-service-preferences/authorizationRules/io-fn-elt"
        name                        = "io-fn-elt"
        # (10 unchanged attributes hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_authorization_rule.events["pdnd-io-cosmosdb-service-preferences.pdnd"] will be updated in-place
  ~ resource "azurerm_eventhub_authorization_rule" "events" {
        id                          = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns/eventhubs/pdnd-io-cosmosdb-service-preferences/authorizationRules/pdnd"
        name                        = "pdnd"
        # (10 unchanged attributes hidden)
    }

  # module.event_hubs_weu.module.event_hub.azurerm_eventhub_namespace.this will be updated in-place
  ~ resource "azurerm_eventhub_namespace" "this" {
        id                                  = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.EventHub/namespaces/io-p-evh-ns"
        name                                = "io-p-evh-ns"
        tags                                = {
            "CostCenter"  = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"   = "Terraform"
            "Environment" = "Prod"
            "Owner"       = "IO"
            "Source"      = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
        }
        # (15 unchanged attributes hidden)
    }

  # module.redis_weu.module.redis_common_backup_zrs.azurerm_storage_account.this will be updated in-place
  ~ resource "azurerm_storage_account" "this" {
        id                                = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Storage/storageAccounts/iopstredisbackup"
        name                              = "iopstredisbackup"
        tags                              = {
            "CostCenter"  = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"   = "Terraform"
            "Environment" = "Prod"
            "Owner"       = "IO"
            "Source"      = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
        }
        # (33 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 37 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.application_gateway_weu.azurerm_web_application_firewall_policy.api_app,
  on ../_modules/application_gateway/firewall.tf line 62, in resource "azurerm_web_application_firewall_policy" "api_app":
  62:         disabled_rules = [
  63:           "942100",
  64:           "942120",
  65:           "942190",
  66:           "942200",
  67:           "942210",
  68:           "942240",
  69:           "942250",
  70:           "942260",
  71:           "942330",
  72:           "942340",
  73:           "942370",
  74:           "942380",
  75:           "942430",
  76:           "942440",
  77:           "942450",
  78:         ]

`disabled_rules` will be removed in favour of the `rule` property in version
4.0 of the AzureRM Provider.

(and 50 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

@Krusty93 Krusty93 enabled auto-merge (squash) September 30, 2024 15:44
Copy link
Contributor

@christian-calabrese christian-calabrese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Krusty93 Krusty93 merged commit 985727c into main Sep 30, 2024
8 checks passed
@Krusty93 Krusty93 deleted the CES-106-rinominare-configurazione-core-legacy branch September 30, 2024 15:44
@gunzip
Copy link
Contributor

gunzip commented Sep 30, 2024

I meant, what about deleting the .utils folder as well :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants