[CES-214] Added new storage account iopweumessagesnotifst for ITN migration #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
21
to
22
| prefix = "io" | ||
| env_short = "p" |
There was a problem hiding this comment.
Prefix and env_short can be gotten from the same variables with var.prefix and var.env_short
Suggested change
| prefix = "io" | |
| env_short = "p" |
| force_public_network_access_enabled = true | ||
|
|
||
| access_tier = "Hot" | ||
|
|
There was a problem hiding this comment.
Suggested change
Comment on lines
28
to
29
| prefix = local.prefix | ||
| env_short = local.env_short |
There was a problem hiding this comment.
Suggested change
| prefix = local.prefix | |
| env_short = local.env_short | |
| prefix = var.prefix | |
| env_short = var.env_short |
Comment on lines
35
to
42
| tags = { | ||
| CostCenter = "TS310 - PAGAMENTI & SERVIZI" | ||
| CreatedBy = "Terraform" | ||
| Environment = "Prod" | ||
| Owner = "IO" | ||
| ManagementTeam = "Comunicazione" | ||
| Source = "https://github.com/pagopa/io-infra/blob/4b82c3e0296174eb27ddbebdb15b4cad17e19430/src/domains/messages-common/04_storage.tf#L35" | ||
| } |
There was a problem hiding this comment.
Tags can be gotten from the variable var.tags
Suggested change
| tags = { | |
| CostCenter = "TS310 - PAGAMENTI & SERVIZI" | |
| CreatedBy = "Terraform" | |
| Environment = "Prod" | |
| Owner = "IO" | |
| ManagementTeam = "Comunicazione" | |
| Source = "https://github.com/pagopa/io-infra/blob/4b82c3e0296174eb27ddbebdb15b4cad17e19430/src/domains/messages-common/04_storage.tf#L35" | |
| } |
Comment on lines
94
to
109
| variable "environment" { | ||
| type = object({ | ||
| prefix = string | ||
| env_short = string | ||
| location = string | ||
| domain = optional(string) | ||
| instance_number = string | ||
| }) | ||
|
|
||
| description = "Values which are used to generate resource names and location short names. They are all mandatory except for domain, which should not be used only in the case of a resource used by multiple domains." | ||
| } | ||
|
|
||
| variable "resource_group_common" { | ||
| type = string | ||
| description = "Name of the common resource group" | ||
| } |
There was a problem hiding this comment.
I would consider populating these values in locals
Suggested change
| variable "environment" { | |
| type = object({ | |
| prefix = string | |
| env_short = string | |
| location = string | |
| domain = optional(string) | |
| instance_number = string | |
| }) | |
| description = "Values which are used to generate resource names and location short names. They are all mandatory except for domain, which should not be used only in the case of a resource used by multiple domains." | |
| } | |
| variable "resource_group_common" { | |
| type = string | |
| description = "Name of the common resource group" | |
| } |
FasanoBip
changed the title
|
Krusty93
reviewed
Dec 10, 2024
| tier = "l" | ||
| resource_group_name = "${local.prefix}-${local.env_short}-${local.location}-messages-notifications-rg" | ||
|
|
||
| force_public_network_access_enabled = true |
There was a problem hiding this comment.
I know it's currently enabled, but I would disable it in the new one.
@lucacavallaro @Garma00 sounds good?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Storage accounts must be replicated to italy north in view of the infrastructure migration
Major Changes
Create replication of iopweumessagesnotifst in italy north
Dependencies
Testing
Documentation
Other Considerations