Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPID-1191] Disabled OnProfileUpdate function #765

Merged
merged 3 commits into from
Dec 4, 2023
Merged

[#IOPID-1191] Disabled OnProfileUpdate function #765

merged 3 commits into from
Dec 4, 2023

Conversation

silvicir
Copy link
Contributor

@silvicir silvicir commented Dec 1, 2023 •
edited
Loading

List of changes

  1. Updated uniqueEmails storage table name with profileEmails
  2. Disabled OnProfileUpdate function both on staging and production slot

Motivation and context

When triggered by cosmosDB change feed, the OnProfileUpdate function will populate the storage table profileEmails. So we need to disable the staging slot and enable the production slot only at the right moment

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information

If PR is partially applied, why? (reserved to mantainers)

How to apply

After PR is approved

  1. run deploy pipeline from Azure DevOps io-platform-iac-projects
  2. select PR branch
  3. wait for approval

@silvicir
updated uniqueEmails storage table name and disabled OnProfileUpdate …
e7e7051 
…function both on staging and production slots
@silvicir silvicir marked this pull request as ready for review December 1, 2023 10:03
@silvicir silvicir requested review from a team as code owners December 1, 2023 10:03
gquadrati
gquadrati previously approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@gquadrati gquadrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small comment.

src/domains/citizen-auth-common/03_storage.tf Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@silvicir silvicir merged commit 3b12f4f into main Dec 4, 2023
7 checks passed
@silvicir silvicir deleted the IOPID-1191-disabled-OnProfileUpdate-function branch December 4, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gquadrati gquadrati gquadrati approved these changes

@lucacavallaro lucacavallaro Awaiting requested review from lucacavallaro lucacavallaro is a code owner automatically assigned from pagopa/io-backend-contributors

@Krusty93 Krusty93 Awaiting requested review from Krusty93 Krusty93 is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
status: applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvicir @gquadrati