Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EC-62] Migrate pipelines to container app jobs and managed identities #811

Merged
merged 11 commits into from
Jan 5, 2024

Conversation

Krusty93
Copy link
Contributor

@Krusty93 Krusty93 commented Jan 3, 2024

List of changes

GitHub Actions now use managed identities and the container app job as private runner

Motivation and context

Migrating all GH Actions to use managed identities and container app jobs

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

How to apply

After PR is approved

  1. run deploy pipeline from Azure DevOps io-platform-iac-projects
  2. select PR branch
  3. wait for approval

src/core/keyvault_access_policy.tf Outdated Show resolved Hide resolved
Copy link
Member

@pasqualedevita pasqualedevita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from reviewers_teams and codeowners we can remove infrastructure-admin (deleted team)

Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@pasqualedevita pasqualedevita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Krusty93 Krusty93 merged commit cfa7240 into main Jan 5, 2024
6 checks passed
@Krusty93 Krusty93 deleted the EC-62-migrazione-pipeline-io-infra branch January 5, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants