-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIW-1936] Bug fix: the revocation time in the email appears without considering the timezone #357
Merged
silvicir
merged 39 commits into
master
from
SIW-1936-fixing-time-zone-wi-revocation-email
Jan 16, 2025
Merged
[SIW-1936] Bug fix: the revocation time in the email appears without considering the timezone #357
silvicir
merged 39 commits into
master
from
SIW-1936-fixing-time-zone-wi-revocation-email
Jan 16, 2025
+26
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v var in the local.settings.json.example file
…il-related code in both SetWalletInstanceStatus and SetCurrentWalletInstanceStatus handlers
… via another function)
…ependencies of the revokeCurrentUserWalletInstance() function
…ame and wallet_instance_creation_email_queue_name
…alletInstanceStatus handlers
…tanceRevocationQueueItem
…lot_disabled list
silvicir
requested changes
Jan 14, 2025
apps/io-wallet-user-func/src/infra/handlers/send-email-on-wallet-instance-revocation.ts
Outdated
Show resolved
Hide resolved
…cation date and the revocation time for the WI revocation email
silvicir
reviewed
Jan 15, 2025
silvicir
requested changes
Jan 16, 2025
apps/io-wallet-user-func/src/infra/handlers/send-email-on-wallet-instance-revocation.ts
Outdated
Show resolved
Hide resolved
silvicir
reviewed
Jan 16, 2025
silvicir
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
I've added and used
date-fns-tz
to handle the timezone of revocation time (expressed inHH:mm
format) and date (expressed indd/MM/yyyy
format) shown in the revocation email sent to the user.Motivation and Context
Actually the revocation time is displayed without considering the time zone. The bug is due to date-fns, which by default does not handle the time zone in the formatting.
How Has This Been Tested?
I created a local function, isolating only the code responsible for sending emails and using the
date-fns-tz
package. I used the postfix server and the mailhog client to emulate an email sending and an incoming mail.These links may be useful:
Screenshots (if appropriate):
Checklist: