Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIW-1936] Bug fix: the revocation time in the email appears without considering the timezone #357

Merged
merged 39 commits into from
Jan 16, 2025

Conversation

christianatzeni
Copy link
Collaborator

List of Changes

I've added and used date-fns-tz to handle the timezone of revocation time (expressed in HH:mm format) and date (expressed in dd/MM/yyyy format) shown in the revocation email sent to the user.

Motivation and Context

Actually the revocation time is displayed without considering the time zone. The bug is due to date-fns, which by default does not handle the time zone in the formatting.

How Has This Been Tested?

I created a local function, isolating only the code responsible for sending emails and using the date-fns-tz package. I used the postfix server and the mailhog client to emulate an email sending and an incoming mail.

These links may be useful:

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

…v var in the local.settings.json.example file
…il-related code in both SetWalletInstanceStatus and SetCurrentWalletInstanceStatus handlers
…ependencies of the revokeCurrentUserWalletInstance() function
…ame and wallet_instance_creation_email_queue_name
@christianatzeni christianatzeni added bug Something isn't working apps internal labels Jan 14, 2025
@christianatzeni christianatzeni self-assigned this Jan 14, 2025
@christianatzeni christianatzeni requested review from a team as code owners January 14, 2025 14:04
@silvicir silvicir merged commit a1cc182 into master Jan 16, 2025
5 checks passed
@silvicir silvicir deleted the SIW-1936-fixing-time-zone-wi-revocation-email branch January 16, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps bug Something isn't working changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants