Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: P4ADEV-1781 add API to get decrypted api-key of broker #8

Merged
merged 16 commits into from
Dec 23, 2024

Conversation

serdimic
Copy link
Collaborator

Description

Add API to get decrypted api-keys of broker

List of Changes

Add API to get decrypted api-keys of broker

Motivation and Context

needed by MS pagopa-payments to interact with PagoPA

How Has This Been Tested?

  • Pre-Deploy Test
    • Unit
    • Integration (Narrow)
  • Post-Deploy Test
    • Isolated Microservice
    • Broader Integration
    • Acceptance
    • Performance & Load

Types of changes

  • PATCH - Bug fix (backwards compatible bug fixes)
  • MINOR - New feature (add functionality in a backwards compatible manner)
  • MAJOR - Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CHORE - Minor Change (fix or feature that don't impact the functionality e.g. Documentation or lint configuration)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

@antonioT90 antonioT90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a test on the BrokerControllerTest (a unit test, not a SpringBootTest)

let's add a test on ControllerExceptionHandlerTest (a WebMvcTest as done here https://github.com/pagopa/idpay-payment/blob/main/src/test/java/it/gov/pagopa/payment/controller/payment/IdPayCodePaymentMilControllerTest.java)
In this test let's import just the BrokerController class in order to test just the, mocking the service to let it throws the exception and verify the 404 response

antonioT90
antonioT90 previously approved these changes Dec 20, 2024
@antonioT90 antonioT90 merged commit 4a929c5 into develop Dec 23, 2024
11 checks passed
@antonioT90 antonioT90 deleted the P4ADEV-1781-add_api_get_decrypted_api_key_broker branch December 23, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants