Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: P4ADEV-1617 added security to bff #5

Merged
merged 14 commits into from
Dec 11, 2024
Merged

feat: P4ADEV-1617 added security to bff #5

merged 14 commits into from
Dec 11, 2024

Conversation

oleksiybozhykntt
Copy link
Collaborator

Description

List of Changes

added security to bff
added token validation

Motivation and Context

How Has This Been Tested?

  • Pre-Deploy Test
    • Unit
    • Integration (Narrow)
  • Post-Deploy Test
    • Isolated Microservice
    • Broader Integration
    • Acceptance
    • Performance & Load

Types of changes

  • PATCH - Bug fix (backwards compatible bug fixes)
  • MINOR - New feature (add functionality in a backwards compatible manner)
  • MAJOR - Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CHORE - Minor Change (fix or feature that don't impact the functionality e.g. Documentation or lint configuration)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@oleksiybozhykntt oleksiybozhykntt marked this pull request as ready for review December 9, 2024 08:36
antonioT90
antonioT90 requested changes Dec 9, 2024
View reviewed changes
src/main/java/it/gov/pagopa/pu/bff/dto/UserInfoDTO.java Outdated Show resolved Hide resolved
src/main/java/it/gov/pagopa/pu/bff/dto/UserOrganizationRolesDTO.java Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
antonioT90
antonioT90 requested changes Dec 9, 2024
View reviewed changes
helm/values-dev.yaml Outdated Show resolved Hide resolved
helm/values-prod.yaml Outdated Show resolved Hide resolved
helm/values-uat.yaml Outdated Show resolved Hide resolved
src/main/java/it/gov/pagopa/pu/bff/service/AuthorizationService.java Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
antonioT90
antonioT90 requested changes Dec 9, 2024
View reviewed changes
build.gradle.kts Outdated Show resolved Hide resolved
src/main/java/it/gov/pagopa/pu/bff/service/AuthorizationService.java Outdated Show resolved Hide resolved
antonioT90
antonioT90 requested changes Dec 10, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@oleksiybozhykntt oleksiybozhykntt merged commit 36b9ca7 into develop Dec 11, 2024
11 checks passed
@oleksiybozhykntt oleksiybozhykntt deleted the P4PADEV-1617-added-spring-security branch December 11, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonioT90 antonioT90 antonioT90 approved these changes

@antocalo antocalo Awaiting requested review from antocalo antocalo is a code owner

@Benedetta-fabbri Benedetta-fabbri Awaiting requested review from Benedetta-fabbri Benedetta-fabbri is a code owner

@LarissaASLeite LarissaASLeite Awaiting requested review from LarissaASLeite LarissaASLeite is a code owner

@RiccardoGiuliani RiccardoGiuliani Awaiting requested review from RiccardoGiuliani RiccardoGiuliani is a code owner

@ElisKina-dev ElisKina-dev Awaiting requested review from ElisKina-dev ElisKina-dev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksiybozhykntt @antonioT90