Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC - 4178] feat: removed required condition for recipientCode and id in Onboardi… #251

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

gianmarcoplutino
Copy link
Contributor

…ngRequestResource

List of Changes

  • removed required condition to recipientCode in OnboardingRequestResource
  • removed required condition to id in OnboardingRequestResource

Motivation and Context

These changes were necessary because recipientCode field is not required for PT, instead for institutionId in the new onboarding flow the institution is created after the onboarding request, for this reason the institutionId is no longer required

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

github-actions bot commented Feb 9, 2024

OpenAPI Diff Report for api-docs

OpenAPI Compatibility Report

Compared Specs: api-docs - api-docs
Report Result: Incompatible

Added Endpoints

Removed Endpoints

Deprecated Endpoints

Changed Endpoints

Get /v2/tokens/{onboardingId} Incompatible
Breaking Changes
  • Operation - Responses - 200 - Content - application/json - Schema - institutionInfo - Required
    • Required Modification
      • Removed id
    • Required Modification
      • Removed recipientCode

@github-actions github-actions bot added the OAS:Incompatible Incompatible OpenAPI Specification changes label Feb 9, 2024
@gianmarcoplutino gianmarcoplutino marked this pull request as ready for review February 9, 2024 15:08
@gianmarcoplutino gianmarcoplutino requested a review from a team as a code owner February 9, 2024 15:08
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@gianmarcoplutino gianmarcoplutino merged commit 1c728e4 into release-dev Feb 9, 2024
3 of 4 checks passed
@manuraf manuraf deleted the feature/SELC-4176 branch March 28, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OAS:Incompatible Incompatible OpenAPI Specification changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants