Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-6247] feat: removed userTaxCode from verify-manager API #385

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

empassaro
Copy link
Collaborator

List of Changes

Turned API verify-manager into GET and updated service code to use common class to perform verification

Motivation and Context

The interface needs to change as it now retrieves the user's taxCode information directly from the JWT token and no longer requests it in the request body. As a result, it was more natural to render the GET method.

How Has This Been Tested?

local env

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

…ice code to use common class to perform verification
@empassaro empassaro requested a review from a team as a code owner December 19, 2024 13:31
@empassaro empassaro changed the title [SELC-6247] feat: turned API verify-manager into GET [SELC-6247] feat: removed userTaxCode from verify-manager API Dec 19, 2024
@empassaro empassaro merged commit cba046a into main Dec 20, 2024
6 of 7 checks passed
@empassaro empassaro deleted the feature/SELC-6248 branch December 20, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants