Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cosmosdb_sql_container): including indexing_policy setting for CosmosDB SQL Container #402

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

andrea-deri
Copy link
Contributor

@andrea-deri andrea-deri commented Jan 16, 2025

This PR contains an improvement on CosmosDB container's TF resource: as defined in official documentation, there is an option that permits to explicitly define a policy about indexing strategy. In particular, there is the possibility to define complex indexes that includes multiple fields into a single index (like compound indexes defined for MongoDB).
This could be useful in most cases where more intensive query are required to be executed.
These updates are made in order to not cause regression from the currently defined structure and are backward compatible with previous versions of the resource cosmosdb_sql_container.

List of changes

  • Included the explicit definition of indexing_policy object in cosmosdb_sql_container component

Motivation and context

These changes are required in order to permits the definition of custom complex indexes on CosmosDB SQL containers

Type of changes

  • Add new module
  • Update existing module
  • Remove existing module

Does this introduce a breaking change?

  • Yes
  • No

Other information

Run checks

Useful commands to run checks on local machine

bash .utils/terraform_run_all.sh init local
pre-commit run -a

@andrea-deri andrea-deri requested review from a team as code owners January 16, 2025 14:43
@andrea-deri andrea-deri self-assigned this Jan 16, 2025
mamari90
mamari90 previously approved these changes Jan 16, 2025
Copy link
Contributor

@mamari90 mamari90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrea-deri andrea-deri merged commit cf14027 into main Jan 16, 2025
4 checks passed
@andrea-deri andrea-deri deleted the feat-cosmosdb-sql-container-indexingpolicy branch January 16, 2025 15:52
Copy link

🎉 This PR is included in version 8.74.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants