Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-cc): add relogin methods #3

Closed
wants to merge 1 commit into from

Conversation

rarajes2
Copy link
Collaborator

@rarajes2 rarajes2 commented Nov 6, 2024

COMPLETES #< SPARK-565067 >

This pull request addresses

Adds the stationReLogin method, with this the client can re login if the connectivity goes off for some time.

by making the following changes

StationReLogin method is available as webex.cc.stationReLogin() and implemented in the samples app with a setTimeout of 5 seconds.

Please check the HAR file attached in the JIRA

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

Added the method call inside the the stationLogin on samples page to be invoked after 5 seconds if the login is successful. Getting a 202 response for the call. Please check the HAR file attached on the JIRA.

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@rarajes2 rarajes2 force-pushed the cc-relogin branch 2 times, most recently from 6818b34 to 057ed63 Compare November 7, 2024 13:16
@rarajes2
Copy link
Collaborator Author

Closing this as Ravi has already taken this change in his PR.

@rarajes2 rarajes2 closed this Nov 12, 2024
rarajes2 pushed a commit that referenced this pull request Nov 13, 2024
feat(cc): getBuddyAgents implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant