Fix KeyError by adding check for _convert_dates #60539
Open
+28
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
requested changes
Dec 27, 2024
Thank you for the review. Please guide me on which test file would be the most appropriate for adding tests for this change. |
|
|
|
@rhshadrach I have added the tests, please check if they are correct. |
rhshadrach
requested changes
Jan 9, 2025
Comment on lines
+2599
to
+2606
| writer._convert_dates = {"old_name": "converted_date"} | ||
| columns = ["new_name"] | ||
| original_columns = ["old_name"] | ||
| for c, o in zip(columns, original_columns): | ||
| if c != o and o in writer._convert_dates: | ||
| writer._convert_dates[c] = writer._convert_dates[o] | ||
| del writer._convert_dates[o] | ||
| assert writer._convert_dates == {"new_name": "converted_date"} |
There was a problem hiding this comment.
Can you instead test using the public API - provide a DataFrame with an name that will be changed, and a convert_dates, then call read_stata to check the result.
Comment on lines
+2593
to
+2594
| def test_convert_dates_key_handling(tmp_path, version): | ||
| temp_file = tmp_path / "test.dta" |
There was a problem hiding this comment.
Can you make the first line of test references the GitHub issue (or PR):
def test_convert_dates_key_handling(tmp_path, version):
# GH#60536
temp_file = tmp_path / "test.dta"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60536
This PR adds a check to prevent a KeyError when renaming columns by ensuring the original column name exists in the _convert_dates dictionary before updating it.