Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable ruf rule in ruff config #441

Merged
merged 1 commit into from
Dec 8, 2023
Merged

chore: enable ruf rule in ruff config #441

merged 1 commit into from
Dec 8, 2023

Conversation

afuetterer
Copy link
Contributor

@afuetterer afuetterer commented Oct 13, 2023 •
edited
Loading

Description

Related issue: #439

Types of changes

  • Code style update (formatting, renaming)

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions
Copy link

github-actions bot commented Oct 13, 2023 •
edited
Loading

📋 Pytest Results

19 tests  ±0   19 ✔️ ±0   25s ⏱️ -2s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit f1c1545. ± Comparison against base commit d226d66.

♻️ This comment has been updated with latest results.

@afuetterer afuetterer mentioned this pull request Oct 13, 2023
Closed
@afuetterer afuetterer marked this pull request as draft October 13, 2023 17:19
@afuetterer afuetterer marked this pull request as ready for review November 30, 2023 09:22
@github-actions GitHub Actions
Copy link

📋 Code Coverage

Code Coverage

Package Line Rate Branch Rate Health
. 50% 35% ❌
config 100% 100% ✔
controllers 87% 60% ✔
evaluators 65% 38% ➖
harvester 63% 52% ➖
helper 66% 56% ➖
models 81% 87% ✔
Summary 71% (6671 / 9425) 61% (2829 / 4641) ➖

@afuetterer
Copy link
Contributor Author

This is another PR that enables a new ruff ruleset for code quality.

@huberrob huberrob merged commit f46c290 into pangaea-data-publisher:master Dec 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afuetterer @huberrob