Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all new Ruff backends to list of plugins #20555

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Add all new Ruff backends to list of plugins #20555

merged 1 commit into from
Feb 16, 2024

Conversation

krishnan-chandra
Copy link
Contributor

@krishnan-chandra krishnan-chandra added category:bugfix Bug fixes for released features backend: Python Python backend-related issues labels Feb 16, 2024
@krishnan-chandra
Copy link
Contributor Author

krishnan-chandra commented Feb 16, 2024 •
edited
Loading

I notice that pants.backend.experimental.typescript is also included in the list of missing backends in #20548 - I didn't include that here because I don't know much about it, but I can include it if you want.

@krishnan-chandra krishnan-chandra changed the title Add all new Ruff backends to list of targets Add all new Ruff backends to list of plugins Feb 16, 2024
@kaos
Copy link
Member

kaos commented Feb 16, 2024

Thanks!

I notice that pants.backend.experimental.typescript is also included in the list of missing backends in #20548 - I didn't include that here because I don't know much about it, but I can include it if you want.

That was as an example only, it was fixed in #20529

@kaos kaos added this to the 2.20.x milestone Feb 16, 2024
@kaos kaos merged commit e3394ad into pantsbuild:main Feb 16, 2024
24 checks passed
WorkerPants pushed a commit that referenced this pull request Feb 16, 2024
@krishnan-chandra @WorkerPants
Add all new Ruff backends to list of plugins (#20555)
5cd3e87 
Related issues and discussions: 

* #20548
* https://pantsbuild.slack.com/archives/C0D7TNJHL/p1708092220006959
@krishnan-chandra krishnan-chandra deleted the fix-ruff-package-inclusion branch February 16, 2024 14:55
@WorkerPants
Copy link
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

✔️ 2.20.x

Successfully opened #20556.

Thanks again for your contributions!

🤖 Beep Boop here's my run link

kaos pushed a commit that referenced this pull request Feb 16, 2024
@WorkerPants @krishnan-chandra
Add all new Ruff backends to list of plugins (Cherry-pick of #20555) (#…
8f5744f 
…20556)

Related issues and discussions: 

* #20548
* https://pantsbuild.slack.com/archives/C0D7TNJHL/p1708092220006959

Co-authored-by: Krishnan Chandra <[email protected]>
@kyujin-cho kyujin-cho mentioned this pull request Apr 7, 2024
Merged
2 tasks
@purajit purajit mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyggen jyggen jyggen approved these changes

@kaos kaos kaos approved these changes

Assignees
No one assigned
Labels
backend: Python Python backend-related issues category:bugfix Bug fixes for released features
Projects
None yet
Milestone
2.20.x
Development

Successfully merging this pull request may close these issues.
4 participants
@krishnan-chandra @kaos @WorkerPants @jyggen