Schnorr signature support #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phpecc/phpecc@master...public-square:phpecc:main The changes in Point.php seem almost all related to linting. The new $windowSize attribute with a setter and getter is not used anywhere, so I haven't imported the changes in that class.
| // scalar is private key if Y is even, otherwise it's order - scalar | ||
| $scalar = $d; | ||
|
|
||
| if ($isEvenY === false) { |
There was a problem hiding this comment.
I would recommend avoiding branches in signing.
| $point = $generator->mul($d); | ||
|
|
||
| // is the Y coordinate even? | ||
| $isEvenY = gmp_cmp(gmp_mod($point->getY(), 2), 0) === 0; |
There was a problem hiding this comment.
Just a head's up, gmp_cmp() is timing-leaky.
|
I've fixed the timing leaks in the master branch, and will cut a release soon. Please feel free to report these to the source repository for this Schnorr implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #28
This PR imports the
SchnorrSignatureclass and its supporting code frompublic-square/phpecc. I just made minimal changes to pass the psalm linter, fix some PHP 8.4 deprecations and make the code compatible with PHP 7.1.The test vectors used in
SchnorrSignatureTestare based on the reference test vectors in Bitcoin Improvement Proposal 340. On a cursory look it doesn't seem like Wycheproof has any additional test vectors for Schnorr signatures.