Dev restruct opt #22
Merged
Dev restruct opt #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uct clasulation and visualisation seperately
…fficient, but UNTESTED.
…Including major improvent on the sum correlations function, compute the correlation matrix once (with numpy) -that depricates for the moment the computation of other than Pearson correlation function.
…he visualisation package.
…al implementation.
…le. More to optimise in a later pass.
…needed elswhere in the app.
… graph interactions. Genome contour load and visualisation.
…nstruction of start sites.
…mand line argument the resolution to reflect teh new functionality and comput the gene 3D coordinates based on its start site.
Dev gene positions
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: The pull request introduces a new modular visualization approach for 3D genome plotting, refactors existing code to improve modularity, and adds new functionality for calculating distances and correlations in gene positions. It also includes the addition of a timing decorator for performance measurement and the removal of an outdated module.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
- Files deleted: Sourcery does not currently approve diffs with deleted files.
General suggestions:
- Ensure that all new functions handle edge cases and potential errors gracefully, especially when dealing with file inputs and external libraries.
- Consider adding comprehensive documentation for the new modules and functions to facilitate easier maintenance and future development.
- Review the implementation of the visualization functions to ensure that all intended data is correctly represented and that no data is inadvertently lost or misrepresented.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First round of implementations for developing the new modular visualisation approach.