Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2412] Backport #7050 #7060

Open
wants to merge 1 commit into
base: stable2412
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ where
// This is done for example when gap syncing and it is expected that the block after the gap
// was checked/chosen properly, e.g. by warp syncing to this block using a finality proof.
if block_params.state_action.skip_execution_checks() || block_params.with_state() {
block_params.fork_choice = Some(ForkChoiceStrategy::Custom(block_params.with_state()));
return Ok(block_params)
}

Expand Down
11 changes: 11 additions & 0 deletions prdoc/pr_7050.prdoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
title: Avoid incomplete block import pipeline with full verifying import queue
doc:
- audience: Node Dev
description: |-
When warp syncing a node using the equivocation checking verifier, we now properly set the fork_choice rule.
Affected are mostly nodes that are derived from the parachain template. Omni-node is not affected.

The prevents the error `ClientImport("Incomplete block import pipeline.")` after state sync.
crates:
- name: cumulus-client-consensus-aura
bump: patch
Loading