-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add error code for email already verified #1438
base: alpha
Are you sure you want to change the base?
feat: add error code for email already verified #1438
Conversation
Thanks for opening this pull request!
|
0a5b63b
to
b143807
Compare
The label |
Codecov Report
@@ Coverage Diff @@
## alpha #1438 +/- ##
========================================
Coverage ? 99.94%
========================================
Files ? 61
Lines ? 5949
Branches ? 1354
========================================
Hits ? 5946
Misses ? 3
Partials ? 0 Continue to review full report at Codecov.
|
b143807
to
8653fd4
Compare
src/ParseError.js
Outdated
* @static | ||
*/ | ||
ParseError.EMAIL_ALREADY_VERIFIED = 212; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the 2nd empty line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for being late. I removed 2nd empty line and push agin.
please check
8653fd4
to
f39a040
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Since this depends on a PR in Parse Server for parse-community/parse-server#7740, we'll wait with merging until a PR has been submitted there.
See parse-community/parse-server##7740
New Pull Request Checklist
Issue Description
This PR adds a new error code when users requestEmailVerification for verified email, now the parse server sends the OTHER_CAUSE error code and it needs a better error code instead of -1 and should have a message instead of stack property.
Related issue:
parse-community/parse-server##7740