Skip to content

Cleanup Boxed Variant #2969

Cleanup Boxed Variant

Cleanup Boxed Variant #2969

Triggered via push January 9, 2025 21:39
Status Success
Total duration 6m 51s
Artifacts

coverage.yml

on: push
Matrix: Build and Test
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 28 warnings
this `map_or` is redundant: extension/partiql-extension-ion/src/decode.rs#L367
error: this `map_or` is redundant --> extension/partiql-extension-ion/src/decode.rs:367:18 | 367 | .any(|a| a.map_or(false, |a| a == annot)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use is_ok_and instead: `a.is_ok_and(|a| a == annot)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or note: the lint level is defined here --> extension/partiql-extension-ion/src/lib.rs:2:9 | 2 | #![deny(clippy::all)] | ^^^^^^^^^^^ = note: `#[deny(clippy::unnecessary_map_or)]` implied by `#[deny(clippy::all)]`
this `map_or` is redundant: extension/partiql-extension-ion/src/decode.rs#L367
error: this `map_or` is redundant --> extension/partiql-extension-ion/src/decode.rs:367:18 | 367 | .any(|a| a.map_or(false, |a| a == annot)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use is_ok_and instead: `a.is_ok_and(|a| a == annot)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or note: the lint level is defined here --> extension/partiql-extension-ion/src/lib.rs:2:9 | 2 | #![deny(clippy::all)] | ^^^^^^^^^^^ = note: `#[deny(clippy::unnecessary_map_or)]` implied by `#[deny(clippy::all)]`
type `boxed_ion::BoxedIonStreamType` is more private than the item `boxed_ion::BoxedIon::parse`: extension/partiql-extension-ion/src/boxed_ion.rs#L468
warning: type `boxed_ion::BoxedIonStreamType` is more private than the item `boxed_ion::BoxedIon::parse` --> extension/partiql-extension-ion/src/boxed_ion.rs:468:5 | 468 | pub fn parse(data: Vec<u8>, expected: BoxedIonStreamType) -> IonResult<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::parse` is reachable at visibility `pub` | note: but type `boxed_ion::BoxedIonStreamType` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:538:1 | 538 | enum BoxedIonStreamType { | ^^^^^^^^^^^^^^^^^^^^^^^ = note: `#[warn(private_interfaces)]` on by default
unused variable: `deserializer`: extension/partiql-extension-ion/src/boxed_ion.rs#L149
warning: unused variable: `deserializer` --> extension/partiql-extension-ion/src/boxed_ion.rs:149:23 | 149 | fn deserialize<D>(deserializer: D) -> std::result::Result<Self, D::Error> | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_deserializer`
unused variable: `serializer`: extension/partiql-extension-ion/src/boxed_ion.rs#L139
warning: unused variable: `serializer` --> extension/partiql-extension-ion/src/boxed_ion.rs:139:28 | 139 | fn serialize<S>(&self, serializer: S) -> std::result::Result<S::Ok, S::Error> | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_serializer` | = note: `#[warn(unused_variables)]` on by default
unused imports: `Deserialize` and `Serialize`: extension/partiql-extension-ion/src/lib.rs#L5
warning: unused imports: `Deserialize` and `Serialize` --> extension/partiql-extension-ion/src/lib.rs:5:13 | 5 | use serde::{Deserialize, Serialize}; | ^^^^^^^^^^^ ^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L164
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:164:13 | 163 | pub struct EvaluationFailAssertion { | ----------------------- field in this struct 164 | pub result: String, | ^^^^^^ | = note: `EvaluationFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L157
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:157:13 | 156 | pub struct EvaluationSuccessAssertion { | -------------------------- field in this struct 157 | pub result: String, | ^^^^^^ | = note: `EvaluationSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L152
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:152:13 | 151 | pub struct StaticAnalysisFailAssertion { | --------------------------- field in this struct 152 | pub result: String, | ^^^^^^ | = note: `StaticAnalysisFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L147
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:147:13 | 146 | pub struct SyntaxFailAssertion { | ------------------- field in this struct 147 | pub result: String, | ^^^^^^ | = note: `SyntaxFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L142
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:142:13 | 141 | pub struct SyntaxSuccessAssertion { | ---------------------- field in this struct 142 | pub result: String, | ^^^^^^ | = note: `SyntaxSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `0` is never read: partiql-conformance-test-generator/src/schema.rs#L75
warning: field `0` is never read --> partiql-conformance-test-generator/src/schema.rs:75:28 | 75 | StaticAnalysisFail(StaticAnalysisFailAssertion), | ------------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 75 | StaticAnalysisFail(()), | ~~
field `0` is never read: partiql-conformance-test-generator/src/schema.rs#L74
warning: field `0` is never read --> partiql-conformance-test-generator/src/schema.rs:74:20 | 74 | SyntaxFail(SyntaxFailAssertion), | ---------- ^^^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 74 | SyntaxFail(()), | ~~
field `0` is never read: partiql-conformance-test-generator/src/schema.rs#L73
warning: field `0` is never read --> partiql-conformance-test-generator/src/schema.rs:73:23 | 73 | SyntaxSuccess(SyntaxSuccessAssertion), | ------------- ^^^^^^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 73 | SyntaxSuccess(()), | ~~
unused imports: `Deserialize` and `Serialize`: partiql-value/src/lib.rs#L30
warning: unused imports: `Deserialize` and `Serialize` --> partiql-value/src/lib.rs:30:13 | 30 | use serde::{Deserialize, Serialize}; | ^^^^^^^^^^^ ^^^^^^^^^
unused imports: `Deserializer` and `Serializer`: partiql-value/src/variant.rs#L14
warning: unused imports: `Deserializer` and `Serializer` --> partiql-value/src/variant.rs:14:26 | 14 | use serde::{Deserialize, Deserializer, Serialize, Serializer}; | ^^^^^^^^^^^^ ^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
type `boxed_ion::BoxedIonStreamType` is more private than the item `boxed_ion::BoxedIon::parse`: extension/partiql-extension-ion/src/boxed_ion.rs#L468
warning: type `boxed_ion::BoxedIonStreamType` is more private than the item `boxed_ion::BoxedIon::parse` --> extension/partiql-extension-ion/src/boxed_ion.rs:468:5 | 468 | pub fn parse(data: Vec<u8>, expected: BoxedIonStreamType) -> IonResult<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::parse` is reachable at visibility `pub` | note: but type `boxed_ion::BoxedIonStreamType` is only usable at visibility `pub(self)` --> extension/partiql-extension-ion/src/boxed_ion.rs:538:1 | 538 | enum BoxedIonStreamType { | ^^^^^^^^^^^^^^^^^^^^^^^ = note: `#[warn(private_interfaces)]` on by default
unused variable: `deserializer`: extension/partiql-extension-ion/src/boxed_ion.rs#L149
warning: unused variable: `deserializer` --> extension/partiql-extension-ion/src/boxed_ion.rs:149:23 | 149 | fn deserialize<D>(deserializer: D) -> std::result::Result<Self, D::Error> | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_deserializer`
unused variable: `serializer`: extension/partiql-extension-ion/src/boxed_ion.rs#L139
warning: unused variable: `serializer` --> extension/partiql-extension-ion/src/boxed_ion.rs:139:28 | 139 | fn serialize<S>(&self, serializer: S) -> std::result::Result<S::Ok, S::Error> | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_serializer` | = note: `#[warn(unused_variables)]` on by default
unused imports: `Deserialize` and `Serialize`: extension/partiql-extension-ion/src/lib.rs#L5
warning: unused imports: `Deserialize` and `Serialize` --> extension/partiql-extension-ion/src/lib.rs:5:13 | 5 | use serde::{Deserialize, Serialize}; | ^^^^^^^^^^^ ^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L164
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:164:13 | 163 | pub struct EvaluationFailAssertion { | ----------------------- field in this struct 164 | pub result: String, | ^^^^^^ | = note: `EvaluationFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L157
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:157:13 | 156 | pub struct EvaluationSuccessAssertion { | -------------------------- field in this struct 157 | pub result: String, | ^^^^^^ | = note: `EvaluationSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L152
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:152:13 | 151 | pub struct StaticAnalysisFailAssertion { | --------------------------- field in this struct 152 | pub result: String, | ^^^^^^ | = note: `StaticAnalysisFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L147
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:147:13 | 146 | pub struct SyntaxFailAssertion { | ------------------- field in this struct 147 | pub result: String, | ^^^^^^ | = note: `SyntaxFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `result` is never read: partiql-conformance-test-generator/src/schema.rs#L142
warning: field `result` is never read --> partiql-conformance-test-generator/src/schema.rs:142:13 | 141 | pub struct SyntaxSuccessAssertion { | ---------------------- field in this struct 142 | pub result: String, | ^^^^^^ | = note: `SyntaxSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
field `0` is never read: partiql-conformance-test-generator/src/schema.rs#L75
warning: field `0` is never read --> partiql-conformance-test-generator/src/schema.rs:75:28 | 75 | StaticAnalysisFail(StaticAnalysisFailAssertion), | ------------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 75 | StaticAnalysisFail(()), | ~~
field `0` is never read: partiql-conformance-test-generator/src/schema.rs#L74
warning: field `0` is never read --> partiql-conformance-test-generator/src/schema.rs:74:20 | 74 | SyntaxFail(SyntaxFailAssertion), | ---------- ^^^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 74 | SyntaxFail(()), | ~~
field `0` is never read: partiql-conformance-test-generator/src/schema.rs#L73
warning: field `0` is never read --> partiql-conformance-test-generator/src/schema.rs:73:23 | 73 | SyntaxSuccess(SyntaxSuccessAssertion), | ------------- ^^^^^^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 73 | SyntaxSuccess(()), | ~~
unused imports: `Deserialize` and `Serialize`: partiql-value/src/lib.rs#L30
warning: unused imports: `Deserialize` and `Serialize` --> partiql-value/src/lib.rs:30:13 | 30 | use serde::{Deserialize, Serialize}; | ^^^^^^^^^^^ ^^^^^^^^^
unused imports: `Deserializer` and `Serializer`: partiql-value/src/variant.rs#L14
warning: unused imports: `Deserializer` and `Serializer` --> partiql-value/src/variant.rs:14:26 | 14 | use serde::{Deserialize, Deserializer, Serialize, Serializer}; | ^^^^^^^^^^^^ ^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default