Fix conformance test name generation for mixed camel-/snake-case #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpschorr
force-pushed
the
feat-conformance-test-names
branch
from
154de65 to
b7eca20
Compare
Conformance comparison report
Number passing in both: 4168 Number failing in both: 557 Number passing in Base (3bcbd2d) but now fail: 0 Number failing in Base (3bcbd2d) but now pass: 0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
==========================================
+ Coverage 81.36% 81.46% +0.10%
==========================================
Files 89 89
Lines 19446 19388 -58
Branches 19446 19388 -58
==========================================
- Hits 15822 15795 -27
+ Misses 3205 3175 -30
+ Partials 419 418 -1 ☔ View full report in Codecov by Sentry. |
alancai98
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test name in the input source are sometimes camelCase, somtimes snake_case, sometimes include ALLCAPS, and sometimes just space separated. This attempts to handle all these cases, as well as them being mixed, when generating output test function names.
The best place to see an example of the changes is in the new tests:
https://github.com/partiql/partiql-lang-rust/pull/531/files#diff-32bd33373ab1201cb93b5adcb18518713148844aef6b0807f26a221b792d031cR110-R121
Cf #511
I do expect the conformance test report for this PR to potentially show changes due to this renaming, though I'm not sure it actually tracks tests that are removed or added, which is what this will appear as.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.