Skip to content

Cleanup Boxed Variant #3002

Cleanup Boxed Variant

Cleanup Boxed Variant #3002

GitHub Actions / clippy succeeded Jan 14, 2025 in 0s

clippy

26 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 26
Note 0
Help 0

Versions

  • rustc 1.84.0 (9fc6b4312 2025-01-07)
  • cargo 1.84.0 (66221abde 2024-11-19)
  • clippy 0.1.84 (9fc6b43126 2025-01-07)

Annotations

Check warning on line 23 in partiql-conformance-tests/src/bin/generate_comparison_report.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item without indentation

warning: doc list item without indentation
  --> partiql-conformance-tests/src/bin/generate_comparison_report.rs:23:5
   |
23 | /// regressed behavior)
   |     ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
   = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
   |
23 | ///   regressed behavior)
   |     ++

Check warning on line 353 in partiql-logical-planner/src/typer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unreachable pattern

warning: unreachable pattern
   --> partiql-logical-planner/src/typer.rs:353:21
    |
353 |                     _ => {
    |                     ^ no value can reach this
    |
note: multiple earlier patterns match some of the same values
   --> partiql-logical-planner/src/typer.rs:353:21
    |
341 |                     Lit::Null | Lit::Missing => self.bld.new_undefined(),
    |                     ------------------------ matches some of the same values
342 |                     Lit::Int8(_) | Lit::Int16(_) | Lit::Int32(_) | Lit::Int64(_) => {
    |                     ------------------------------------------------------------ matches some of the same values
...
345 |                     Lit::Decimal(_) => type_decimal!(self.bld),
    |                     --------------- matches some of the same values
346 |                     Lit::Double(_) => type_float64!(self.bld),
    |                     -------------- matches some of the same values
...
353 |                     _ => {
    |                     ^ ...and 6 other patterns collectively make this unreachable
    = note: `#[warn(unreachable_patterns)]` on by default

Check warning on line 164 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:164:13
    |
163 |     pub struct EvaluationFailAssertion {
    |                ----------------------- field in this struct
164 |         pub result: String,
    |             ^^^^^^
    |
    = note: `EvaluationFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 157 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:157:13
    |
156 |     pub struct EvaluationSuccessAssertion {
    |                -------------------------- field in this struct
157 |         pub result: String,
    |             ^^^^^^
    |
    = note: `EvaluationSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 152 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:152:13
    |
151 |     pub struct StaticAnalysisFailAssertion {
    |                --------------------------- field in this struct
152 |         pub result: String,
    |             ^^^^^^
    |
    = note: `StaticAnalysisFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 147 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:147:13
    |
146 |     pub struct SyntaxFailAssertion {
    |                ------------------- field in this struct
147 |         pub result: String,
    |             ^^^^^^
    |
    = note: `SyntaxFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 142 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:142:13
    |
141 |     pub struct SyntaxSuccessAssertion {
    |                ---------------------- field in this struct
142 |         pub result: String,
    |             ^^^^^^
    |
    = note: `SyntaxSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 75 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:75:28
   |
75 |         StaticAnalysisFail(StaticAnalysisFailAssertion),
   |         ------------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
   = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
75 |         StaticAnalysisFail(()),
   |                            ~~

Check warning on line 74 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:74:20
   |
74 |         SyntaxFail(SyntaxFailAssertion),
   |         ---------- ^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
   = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
74 |         SyntaxFail(()),
   |                    ~~

Check warning on line 73 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:73:23
   |
73 |         SyntaxSuccess(SyntaxSuccessAssertion),
   |         ------------- ^^^^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
   = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
73 |         SyntaxSuccess(()),
   |                       ~~

Check warning on line 149 in partiql-eval/src/eval/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `serde`

warning: unexpected `cfg` condition value: `serde`
   --> partiql-eval/src/eval/mod.rs:149:12
    |
149 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
    |            ^^^^^^^^^^^^^^^^^ help: remove the condition
    |
    = note: no expected values for `feature`
    = help: consider adding `serde` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
    = note: `#[warn(unexpected_cfgs)]` on by default

Check warning on line 15 in partiql-conformance-tests/build.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

spawned process is never `wait()`ed on

warning: spawned process is never `wait()`ed on
  --> partiql-conformance-tests/build.rs:11:5
   |
11 | /     Command::new("cargo")
12 | |         .arg("fmt")
13 | |         .arg("--")
14 | |         .spawn()
15 | |         .expect("cargo fmt of tests/ failed");
   | |                                             ^- help: try: `.wait()`
   | |_____________________________________________|
   |
   |
   = note: not doing so might leave behind zombie processes
   = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes
   = note: `#[warn(clippy::zombie_processes)]` on by default

Check warning on line 468 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type `boxed_ion::BoxedIonStreamType` is more private than the item `boxed_ion::BoxedIon::parse`

warning: type `boxed_ion::BoxedIonStreamType` is more private than the item `boxed_ion::BoxedIon::parse`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:468:5
    |
468 |     pub fn parse(data: Vec<u8>, expected: BoxedIonStreamType) -> IonResult<Self> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::parse` is reachable at visibility `pub`
    |
note: but type `boxed_ion::BoxedIonStreamType` is only usable at visibility `pub(self)`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:538:1
    |
538 | enum BoxedIonStreamType {
    | ^^^^^^^^^^^^^^^^^^^^^^^
    = note: `#[warn(private_interfaces)]` on by default

Check warning on line 149 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `deserializer`

warning: unused variable: `deserializer`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:149:23
    |
149 |     fn deserialize<D>(deserializer: D) -> std::result::Result<Self, D::Error>
    |                       ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_deserializer`

Check warning on line 139 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `serializer`

warning: unused variable: `serializer`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:139:28
    |
139 |     fn serialize<S>(&self, serializer: S) -> std::result::Result<S::Ok, S::Error>
    |                            ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_serializer`
    |
    = note: `#[warn(unused_variables)]` on by default

Check warning on line 5 in extension/partiql-extension-ion/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `Deserialize` and `Serialize`

warning: unused imports: `Deserialize` and `Serialize`
 --> extension/partiql-extension-ion/src/lib.rs:5:13
  |
5 | use serde::{Deserialize, Serialize};
  |             ^^^^^^^^^^^  ^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

Check warning on line 30 in partiql-value/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `Deserialize` and `Serialize`

warning: unused imports: `Deserialize` and `Serialize`
  --> partiql-value/src/lib.rs:30:13
   |
30 | use serde::{Deserialize, Serialize};
   |             ^^^^^^^^^^^  ^^^^^^^^^

Check warning on line 15 in partiql-value/src/variant.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `Deserializer` and `Serializer`

warning: unused imports: `Deserializer` and `Serializer`
  --> partiql-value/src/variant.rs:15:26
   |
15 | use serde::{Deserialize, Deserializer, Serialize, Serializer};
   |                          ^^^^^^^^^^^^             ^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

Check warning on line 164 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:164:13
    |
163 |     pub struct EvaluationFailAssertion {
    |                ----------------------- field in this struct
164 |         pub result: String,
    |             ^^^^^^
    |
    = note: `EvaluationFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 157 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:157:13
    |
156 |     pub struct EvaluationSuccessAssertion {
    |                -------------------------- field in this struct
157 |         pub result: String,
    |             ^^^^^^
    |
    = note: `EvaluationSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 152 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:152:13
    |
151 |     pub struct StaticAnalysisFailAssertion {
    |                --------------------------- field in this struct
152 |         pub result: String,
    |             ^^^^^^
    |
    = note: `StaticAnalysisFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 147 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:147:13
    |
146 |     pub struct SyntaxFailAssertion {
    |                ------------------- field in this struct
147 |         pub result: String,
    |             ^^^^^^
    |
    = note: `SyntaxFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 142 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:142:13
    |
141 |     pub struct SyntaxSuccessAssertion {
    |                ---------------------- field in this struct
142 |         pub result: String,
    |             ^^^^^^
    |
    = note: `SyntaxSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 75 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:75:28
   |
75 |         StaticAnalysisFail(StaticAnalysisFailAssertion),
   |         ------------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
   = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
75 |         StaticAnalysisFail(()),
   |                            ~~

Check warning on line 74 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:74:20
   |
74 |         SyntaxFail(SyntaxFailAssertion),
   |         ---------- ^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
   = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
74 |         SyntaxFail(()),
   |                    ~~