Move tests that include ion data into locations under an ion subpath
#129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alancai98
approved these changes
Oct 25, 2024
| @@ -0,0 +1,9 @@ | |||
|
|
|||
| // TODO [joshsp] : In a lazy-document context, this is a data error, not a syntax error | |||
There was a problem hiding this comment.
So perhaps this test along w/ the test in partiql-tests-data/fail/syntax/ion/primitives/time-constructor.ion should still successfully parse?
| @@ -191,18 +191,6 @@ cardinality::[ | |||
| output:1 | |||
| } | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Should this test also be replicated using non-Ion syntax
There was a problem hiding this comment.
cardinality({'a': 'missing'}) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to make make it clear where Ion data is used in the partiql-tests.
Many places quoted Ion was used where it was unneccesary, and is thus replaced.
For example:
[`true`]is replaced with[TRUE]{a: 1}is replaced with{'a': 1}In places that Ion data is appropriate and used to test integration with Ion, the test cases are moved into new files under an
ionsub-directory.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.