Add allow-duplicate-cn command-line flag #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AvaxVPN-Team - I am very sorry for the delayed response here. Additionally - I am thinking of adding an end-to-end test suite for the different samples. Would you be keen on taking this over as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request utilizes the Peer ID to uniquely identify each request, with the lowest cardinality possible. The Peer ID a unique ID for each connection, given by the OpenVPN itself in the log file, which is started from 0 and incremented by each new connection.
The good point of this method is that if any of the old ID's get disconnected, those empty spaces will be filled when someone new connects, this way, this number will almost always remain under the maximum client count of your server, and a cardinality of roughly
n^2could be expected wherenis the maximum expected simultaneous client count. It is an opt-in feature, which will get activated by this flag:--allow-duplicate-cn.This fixes #15.