Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hal rtc optimization #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Hal rtc optimization #65

wants to merge 1 commit into from

Conversation

mariusz-wisniewski-at-mobica-dot-com
Copy link

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

paul-szczepanek-arm
paul-szczepanek-arm requested changes Dec 18, 2019
View reviewed changes
targets/TARGET_STM/TARGET_STM32L0/device/stm32l0xx_hal_rtc.c
@@ -441,6 +442,8 @@ HAL_StatusTypeDef HAL_RTC_SetTime(RTC_HandleTypeDef *hrtc, RTC_TimeTypeDef *sTim
(((uint32_t)sTime->TimeFormat) << 16U));
}
else
// else
#else
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoud be endif

targets/TARGET_STM/TARGET_STM32L0/device/stm32l0xx_hal_rtc.c
@@ -460,6 +463,8 @@ HAL_StatusTypeDef HAL_RTC_SetTime(RTC_HandleTypeDef *hrtc, RTC_TimeTypeDef *sTim
((uint32_t)sTime->Seconds) | \
((uint32_t)(sTime->TimeFormat) << 16U));
}
#endif
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-szczepanek-arm paul-szczepanek-arm paul-szczepanek-arm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariusz-wisniewski-at-mobica-dot-com @paul-szczepanek-arm @Vittek1978