[YUNIKORN-2157] Data race in TestStoreWithLimitedSize (apache#716)

Closes: apache#716

Signed-off-by: Peter Bacsko <[email protected]>

pkg/events/event_store.go

@@ -25,7 +25,7 @@ import (
 	"github.com/apache/yunikorn-scheduler-interface/lib/go/si"
 )
 
-var defaultEventStoreSize = 1000
+const defaultEventStoreSize = 1000
 
 // The EventStore operates under the following assumptions:
 //   - there is a cap for the number of events stored
@@ -40,8 +40,12 @@ type EventStore struct {
 }
 
 func newEventStore() *EventStore {
+	return newEventStoreWithSize(defaultEventStoreSize)
+}
+
+func newEventStoreWithSize(size int) *EventStore {
 	return &EventStore{
-		events: make([]*si.EventRecord, defaultEventStoreSize),
+		events: make([]*si.EventRecord, size),
 	}
 }
 

pkg/events/event_store_test.go

@@ -54,12 +54,8 @@ func TestStoreAndRetrieve(t *testing.T) {
 // if we push more events to the EventStore than its
 // allowed maximum, those that couldn't fit will be omitted
 func TestStoreWithLimitedSize(t *testing.T) {
-	defaultEventStoreSize = 3
-	defer func() {
-		defaultEventStoreSize = 1000
-	}()
+	store := newEventStoreWithSize(3)
 
-	store := newEventStore()
 	for i := 0; i < 5; i++ {
 		event := &si.EventRecord{
 			Type:        si.EventRecord_REQUEST,