Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: use the count to break early instead of segfault #19

Closed
wants to merge 1 commit into from

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Nov 26, 2024

https://jira.slac.stanford.edu/browse/ECS-6914

Notes to future me about past me:

  • There's at least one error here in the implementation
  • There are more efficient ways to do this, such as checking the pointer location or cutting early via multiplying width x height and checking it against count
  • The most important things here for the Jira are preventing the segfault and telling the user what is wrong with their camera config

@ZLLentz
Copy link
Member Author

ZLLentz commented Dec 17, 2024

I've decided to implement this by finding the maximum number of rows we can fill given the buffer count and setting the end parameters for the nested loop lower if the count is low. This will be simpler than what's in the PR diff here.

Separately, I want to check apparent count vs pixel count and let the user know if there is a discrepancy.

@ZLLentz
Copy link
Member Author

ZLLentz commented Dec 18, 2024

closed in favor of #22

@ZLLentz ZLLentz closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant