Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: make sure the next env covers new CVEs #306

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Nov 13, 2023

  • Add a place to put security-based/CVE response pins and populate it
  • Ignore the incorrect mkdocs CVE

I think I'd rather do this as we go instead of all at once at env tag time

@ZLLentz
Copy link
Member Author

ZLLentz commented Nov 13, 2023

Well, this makes next incr pass, which is something I guess. The current env failure reflects the reality that the current env has some known vulnerabilities.

@ZLLentz ZLLentz marked this pull request as ready for review November 13, 2023 20:56
@ZLLentz ZLLentz requested a review from tangkong November 13, 2023 20:56
@@ -11,6 +11,7 @@
ACK_LIST = {
"GHSA-29gw-9793-fvw7": "Windows-only",
"PYSEC-2023-163": "Only affects langchain users",
"PYSEC-2021-878": "Fixed in 1.2.2, mistakenly attached to 1.5.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more info on this for my own education

I've recently started to hear about people submitting CVE's maliciously, a fascinating world software is

Copy link
Contributor

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍 I've not really scrutinized the failed tests, since we'll have to re-examine them at env build time anyway

@ZLLentz ZLLentz merged commit d0a6d41 into pcdshub:master Nov 13, 2023
3 of 9 checks passed
@ZLLentz ZLLentz deleted the maint_sec branch November 13, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants