Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: remove ophyd async #333

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

tangkong
Copy link
Contributor

We don't depend on ophyd-async (yet?), and it was the cause of some amount of build conflicts.

Instead I advocate we remove it and have people venv it if they want

Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to remove it
I suspect the build conflicts will go away on their own if we fix nabs's dependency issues
But if it's not being used (yet) and it adds friction, let's reduce friction

@ZLLentz
Copy link
Member

ZLLentz commented Jun 20, 2024

The CI will probably fail no matter what but we should merge anyway

@tangkong tangkong merged commit 4c1fc7a into pcdshub:master Jun 20, 2024
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants