Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]:add oceanbase support #9753

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

xxsc0529
Copy link

@xxsc0529 xxsc0529 commented Dec 6, 2024

[description]
Added support for Oceanbase MySQL mode and OceanBase Oracle mode
[Test]
The MySQL mode of OceanBase is the same as that of MySQL, and the Oracle mode of OceanBase is the same as that of Oracle. When pruning, MySQL uses the delete logic, and OceanBase expects to use the truncate logic
org.pentaho.di.core.database.OceanBaseOracleDatabaseMetaTest

@xxsc0529 xxsc0529 requested a review from a team as a code owner December 6, 2024 09:03
@buildguy

This comment has been minimized.

@buildguy

This comment has been minimized.

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
30.6% Coverage on New Code (required ≥ 80%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@buildguy
Copy link
Collaborator

buildguy commented Dec 9, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.


@buildguy
Copy link
Collaborator

buildguy commented Dec 9, 2024

⚠️ Build finished in 21m 52s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl core

⛔ Failed Tests

⛈️ 1 test(s) failed:

org.pentaho.di.core.database.OceanBaseOracleDatabaseMetaTest.testOverriddenSettings (click to expand)

expected:<jdbc:oceanbase:[@FOO:1024:BAR]> but was:<jdbc:oceanbase:[//FOO:1024?useUnicode=true&characterEncoding=utf8&connectTimeout=30000&rewriteBatchedStatements=true]>

Tests run: 1403, Failures: 1, Skipped: 1    Test Results


ℹ️ This is an automatic message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants