Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cu): select cached messages with correct seq where clause #1102

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

jfrain99
Copy link
Contributor

@jfrain99 jfrain99 commented Jan 7, 2025

Seq was being evaluated as a string, leading to incorrect orderings (ie, '0:2' > '0:15'). Fixes this to compare epoch and nonce numerically.

@jfrain99 jfrain99 force-pushed the jfrain99/cu-fix-where-seq-clause branch from fdaf89e to 44fee3b Compare January 7, 2025 21:00
@jfrain99 jfrain99 requested a review from TillaTheHun0 January 13, 2025 19:46
@jfrain99 jfrain99 force-pushed the jfrain99/cu-fix-where-seq-clause branch from 44fee3b to e37e8f2 Compare January 13, 2025 21:56
Copy link
Member

@TillaTheHun0 TillaTheHun0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfrain99 jfrain99 merged commit 1fd0bff into main Jan 14, 2025
3 checks passed
@jfrain99 jfrain99 deleted the jfrain99/cu-fix-where-seq-clause branch January 14, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants