Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unnecessary qualification #1024

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

austriancoder
Copy link
Contributor

@austriancoder austriancoder commented Jul 2, 2024

Fixes a build problem I am seeing here: https://gitlab.freedesktop.org/austriancoder/mesa/-/jobs/60583390#L4447

Summary by CodeRabbit

  • Refactor
    • Simplified internal import statements for better code readability and maintenance. No impact on end-user functionality.

@austriancoder austriancoder requested a review from a team as a code owner July 2, 2024 05:50
@austriancoder austriancoder requested review from NoahTheDuke and removed request for a team July 2, 2024 05:50
Copy link
Contributor

coderabbitai bot commented Jul 2, 2024

Walkthrough

The recent changes in the pest/src/iterators/pair.rs file involve updates to import statements and internal span handling. The module prefix has been removed from Span::new_internal calls, and the import statement for Span has been simplified. These changes aim to clean up the code and make it more concise and readable.

Changes

File Change Summary
pest/src/iterators/pair.rs Removed the module prefix span:: from Span::new_internal calls and simplified the import statement from crate::span::{self, Span} to crate::span::Span.

Poem

In the code where spans align,
Refactoring now makes them shine,
Prefix dropped, imports neat,
Clean and simple, such a feat.
Pest's pair now swift and lean,
Like a rabbit, quick and keen.


Tip

Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b858b4a and 9984f58.

Files selected for processing (1)
  • pest/src/iterators/pair.rs (1 hunks)
Additional comments not posted (1)
pest/src/iterators/pair.rs (1)

207-207: Unnecessary qualification removed.

The span:: qualification was redundant since Span is already imported from crate::span. This change simplifies the code without affecting functionality.

Signed-off-by: Christian Gmeiner <[email protected]>
@austriancoder austriancoder force-pushed the fix-unused-qualifications branch from 9984f58 to e8e323f Compare July 2, 2024 08:51
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9984f58 and e8e323f.

Files selected for processing (1)
  • pest/src/iterators/pair.rs (2 hunks)
Files skipped from review due to trivial changes (1)
  • pest/src/iterators/pair.rs

@tomtau tomtau merged commit 34792f8 into pest-parser:master Jul 2, 2024
9 checks passed
renovate bot referenced this pull request in rosetta-rs/parse-rosetta-rs Aug 1, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [peg](https://togithub.com/kevinmehall/rust-peg) | dependencies |
patch | `0.8.3` -> `0.8.4` |
| [pest](https://pest.rs/)
([source](https://togithub.com/pest-parser/pest)) | dependencies | patch
| `2.7.10` -> `2.7.11` |
| [serde_json](https://togithub.com/serde-rs/json) | dependencies |
patch | `1.0.119` -> `1.0.121` |
| [winnow](https://togithub.com/winnow-rs/winnow) | dependencies | patch
| `0.6.13` -> `0.6.18` |

---

### Release Notes

<details>
<summary>kevinmehall/rust-peg (peg)</summary>

###
[`v0.8.4`](https://togithub.com/kevinmehall/rust-peg/releases/tag/0.8.4)

[Compare
Source](https://togithub.com/kevinmehall/rust-peg/compare/0.8.3...0.8.4)

#### Fixes

- Fix macro panic for parse error at end of `peg::parser!{ }`
specification
([https://github.com/kevinmehall/rust-peg/issues/376](https://togithub.com/kevinmehall/rust-peg/issues/376))
by [@&#8203;kevinmehall](https://togithub.com/kevinmehall)
- Fix handling of `r#` raw idents
([#&#8203;378](https://togithub.com/kevinmehall/rust-peg/issues/378)) by
[@&#8203;A4-Tacks](https://togithub.com/A4-Tacks) in
[https://github.com/kevinmehall/rust-peg/pull/379](https://togithub.com/kevinmehall/rust-peg/pull/379)

**Full Changelog**:
kevinmehall/rust-peg@0.8.3...0.8.4

</details>

<details>
<summary>pest-parser/pest (pest)</summary>

###
[`v2.7.11`](https://togithub.com/pest-parser/pest/releases/tag/v2.7.11)

[Compare
Source](https://togithub.com/pest-parser/pest/compare/v2.7.10...v2.7.11)

##### What's Changed

- Avoid computing line offsets after the last token by
[@&#8203;wabain](https://togithub.com/wabain) in
[https://github.com/pest-parser/pest/pull/1023](https://togithub.com/pest-parser/pest/pull/1023)
- fix: Remove unnecessary qualification by
[@&#8203;austriancoder](https://togithub.com/austriancoder) in
[https://github.com/pest-parser/pest/pull/1024](https://togithub.com/pest-parser/pest/pull/1024)

##### New Contributors

- [@&#8203;wabain](https://togithub.com/wabain) made their first
contribution in
[https://github.com/pest-parser/pest/pull/1023](https://togithub.com/pest-parser/pest/pull/1023)
- [@&#8203;austriancoder](https://togithub.com/austriancoder) made their
first contribution in
[https://github.com/pest-parser/pest/pull/1024](https://togithub.com/pest-parser/pest/pull/1024)

**Full Changelog**:
pest-parser/pest@v2.7.10...v2.7.11

##### Warning: Semantic Versioning

Note that the node tag feature in 2.6.0 was a technically
semver-breaking change even though it is a backwards-compatible /
non-breaking change in the meta-grammar. There may be similar
non-breaking changes to the meta-grammar between minor versions in the
future. These non-breaking changes, however, may translate into
semver-breaking changes due to the additional variants propagated from
the generated `Rule` enum.

This new feature caused issues in some Cargo version resolution
situations where Cargo mixed different versions of pest dependencies.
For this reason, these "grammar non-breaking but semver-breaking"
changes are now available only under the "grammar-extras" feature flag.
If you would like to use node tags (or other future grammar features),
you can do so by enabling this flag on the pest_derive crate in your
Cargo.toml:

    ...
    pest_derive = { version = "2.7", features = ["grammar-extras"] }

</details>

<details>
<summary>serde-rs/json (serde_json)</summary>

###
[`v1.0.121`](https://togithub.com/serde-rs/json/releases/tag/v1.0.121)

[Compare
Source](https://togithub.com/serde-rs/json/compare/v1.0.120...v1.0.121)

- Optimize position search in error path
([#&#8203;1160](https://togithub.com/serde-rs/json/issues/1160), thanks
[@&#8203;purplesyringa](https://togithub.com/purplesyringa))

###
[`v1.0.120`](https://togithub.com/serde-rs/json/releases/tag/v1.0.120)

[Compare
Source](https://togithub.com/serde-rs/json/compare/v1.0.119...v1.0.120)

- Correctly specify required version of `indexmap` dependency
([#&#8203;1152](https://togithub.com/serde-rs/json/issues/1152), thanks
[@&#8203;cforycki](https://togithub.com/cforycki))

</details>

<details>
<summary>winnow-rs/winnow (winnow)</summary>

###
[`v0.6.18`](https://togithub.com/winnow-rs/winnow/blob/HEAD/CHANGELOG.md#0618---2024-07-31)

[Compare
Source](https://togithub.com/winnow-rs/winnow/compare/v0.6.17...v0.6.18)

###
[`v0.6.17`](https://togithub.com/winnow-rs/winnow/blob/HEAD/CHANGELOG.md#0617---2024-07-31)

[Compare
Source](https://togithub.com/winnow-rs/winnow/compare/v0.6.16...v0.6.17)

##### Features

-   Make `Checkpoint`s comparable

###
[`v0.6.16`](https://togithub.com/winnow-rs/winnow/blob/HEAD/CHANGELOG.md#0616---2024-07-25)

[Compare
Source](https://togithub.com/winnow-rs/winnow/compare/v0.6.15...v0.6.16)

###
[`v0.6.15`](https://togithub.com/winnow-rs/winnow/blob/HEAD/CHANGELOG.md#0615---2024-07-22)

[Compare
Source](https://togithub.com/winnow-rs/winnow/compare/v0.6.14...v0.6.15)

##### Compatibility

-   Deprecated `Parser::recognize` in favor of `Parser::take`
-   Deprecated `Parser::with_recognized` in favor of `Parser::taken`

##### Fixes

- Renamed `Parser::recognize` to `Parser::take` to be consistent with
other `take` parsers
- Renamed `Parser::with_recognized` to `Parser::with_taken` to be
consistent with other `take` parsers

###
[`v0.6.14`](https://togithub.com/winnow-rs/winnow/blob/HEAD/CHANGELOG.md#0614---2024-07-19)

[Compare
Source](https://togithub.com/winnow-rs/winnow/compare/v0.6.13...v0.6.14)

##### Fixes

-   Removed unused `I: Clone` bound on `Parser::parse`

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 5am on the first day of the
month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/rosetta-rs/parse-rosetta-rs).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants