Change struct Configuration to enum Configs #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophie-cluml
force-pushed
the
sophie/enum-configs
branch
from
ceed94d to
0823363
Compare
minshao
approved these changes
Feb 20, 2024
|
@sophie-cluml hog giganto_address 추가해주세요 |
|
이미 crusher에 적용되어있는 수정 가능한 configuration은 기존과 같이 giganto의 |
sophie-cluml
force-pushed
the
sophie/enum-configs
branch
2 times, most recently
from
f69698a to
ee73ab6
Compare
|
@BLYKIM I added |
BLYKIM
reviewed
Feb 21, 2024
src/request.rs
Outdated
| #[derive(Debug, Deserialize, Serialize)] | ||
| pub struct CrusherConfig { | ||
| pub review_address: SocketAddr, | ||
| pub gignato_ingest_address: SocketAddr, |
There was a problem hiding this comment.
gignato -> giganto , Option<SocketAddr>로 변경 부탁드려요
sophie-cluml
force-pushed
the
sophie/enum-configs
branch
from
ee73ab6 to
9a7098c
Compare
BLYKIM
suggested changes
Feb 21, 2024
CHANGELOG.md
Outdated
| @@ -248,6 +255,7 @@ without relying on the content of the response. | |||
|
|
|||
| - `send_frame` and `recv_frame` to send and receive length-delimited frames. | |||
|
|
|||
| [Unreleased]: https://github.com/petabi/oinq/compare/0.9.1...main | |||
There was a problem hiding this comment.
Thank you, done!
sophie-cluml
force-pushed
the
sophie/enum-configs
branch
from
9a7098c to
d4bd2fc
Compare
BLYKIM
approved these changes
Feb 21, 2024
minshao
reviewed
Feb 21, 2024
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - Change struct `Configuration` to enum `Configs` and define configuration by |
There was a problem hiding this comment.
Could you change this to past tense please?
src/request.rs
Outdated
| pub giganto_name: Option<String>, | ||
| pub dump_file: Option<String>, | ||
| pub dump_size: Option<usize>, | ||
| pub enum Configs { |
There was a problem hiding this comment.
Config would be more appropriate, as enum could only be one of the Config kind.
sophie-cluml
force-pushed
the
sophie/enum-configs
branch
from
d4bd2fc to
d592c2b
Compare
minshao
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #58
@BLYKIM @dayeon5470 please help double-check if each module's Configs are okay.