Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance backup::create to support PostgreSQL backup #71

Open
msk opened this issue May 23, 2023 · 0 comments
Open

Enhance backup::create to support PostgreSQL backup #71

msk opened this issue May 23, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@msk
Copy link
Contributor

msk commented May 23, 2023

Description:

Currently, the backup::create function creates a backup for RocksDB databases. To increase our application's versatility and usefulness, we want to extend this function to also support backups for PostgreSQL databases.

This enhancement requires the function to run the pg_dump external command to create a PostgreSQL backup, storing the resulting file in the backup directory. Additionally, the filename must contain the same backup ID as the RocksDB backup created within the same function call. This is to ensure that the matching RocksDB/PostgreSQL backup pair can be easily selected when a user decides to restore from backups.

Acceptance Criteria:

  1. backup::create should be able to create a backup for PostgreSQL databases.
  2. The function should use the pg_dump command to create the PostgreSQL backup.
  3. The backup file should be stored in the backup directory.
  4. The filename of the PostgreSQL backup should contain the same backup ID as the RocksDB backup created within the same function call to backup::create.
@msk msk added the enhancement New feature or request label May 23, 2023
@msk msk mentioned this issue May 26, 2023
Open
kimhanbeom pushed a commit to kimhanbeom/review-database that referenced this issue Jun 23, 2023
Enhance backup logic
bdf5698 
- Added new module 'postgres' to support postgresql.
- Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery`
  function to support postgresql.
- Added `backup::purge_old_backups` for apply immediately after
  `num_backups_to_keep` is changed.

Closes: petabi#71, petabi#76, petabi#80
kimhanbeom pushed a commit to kimhanbeom/review-database that referenced this issue Jun 23, 2023
Enhance backup logic
775c1d6 
- Added new module 'postgres' to support postgresql.
- Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery`
  function to support postgresql.
- Added `backup::purge_old_backups` for apply immediately after
  `num_backups_to_keep` is changed.

Closes: petabi#71, petabi#76, petabi#80
@kimhanbeom kimhanbeom mentioned this issue Jun 23, 2023
Closed
kimhanbeom pushed a commit to kimhanbeom/review-database that referenced this issue Jun 23, 2023
Enhance backup logic
c1cc81f 
- Added new module 'postgres' to support postgresql.
- Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery`
  function to support postgresql.
- Added `backup::purge_old_backups` for apply immediately after
  `num_backups_to_keep` is changed.

Closes: petabi#71, petabi#76, petabi#80
kimhanbeom pushed a commit to kimhanbeom/review-database that referenced this issue Jun 27, 2023
Enhance backup logic
e93f5d3 
- Added new module 'postgres' to support postgresql.
- Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery`
  function to support postgresql.
- Added `backup::purge_old_backups` for apply immediately after
  `num_backups_to_keep` is changed.

Closes: petabi#71, petabi#76, petabi#80
kimhanbeom pushed a commit to kimhanbeom/review-database that referenced this issue Jun 28, 2023
Enhance backup logic
ea5c2e5 
- Added new module 'postgres' to support postgresql.
- Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery`
  function to support postgresql.
- Added `backup::purge_old_backups` for apply immediately after
  `num_backups_to_keep` is changed.

Closes: petabi#71, petabi#76, petabi#80
kimhanbeom pushed a commit to kimhanbeom/review-database that referenced this issue Jun 29, 2023
Enhance backup logic
30c0158 
- Added new module 'postgres' to support postgresql.
- Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery`
  function to support postgresql.
- Added `backup::purge_old_backups` for apply immediately after
  `num_backups_to_keep` is changed.

Closes: petabi#71, petabi#76, petabi#80
kimhanbeom pushed a commit to kimhanbeom/review-database that referenced this issue Jul 6, 2023
Enhance backup logic
50a163a 
- Added new module 'postgres' to support postgresql.
- Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery`
  function to support postgresql.
- Added `backup::purge_old_backups` for apply immediately after
  `num_backups_to_keep` is changed.

Closes: petabi#71, petabi#76, petabi#80
kimhanbeom pushed a commit to kimhanbeom/review-database that referenced this issue Jul 6, 2023
Enhance backup logic
b778e50 
- Added new module 'postgres' to support postgresql.
- Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery`
  function to support postgresql.
- Added `backup::purge_old_backups` for apply immediately after
  `num_backups_to_keep` is changed.

Closes: petabi#71, petabi#76, petabi#80
kimhanbeom pushed a commit to kimhanbeom/review-database that referenced this issue Jul 6, 2023
Enhance backup logic
6aa6b1a 
- Added new module 'postgres' to support postgresql.
- Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery`
  function to support postgresql.
- Added `backup::purge_old_backups` for apply immediately after
  `num_backups_to_keep` is changed.

Closes: petabi#71, petabi#76, petabi#80
@msk msk mentioned this issue Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Enhance backup logic kimhanbeom/review-database
1 participant
@msk