Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Enhance backup logic #105

Closed
wants to merge 1 commit into from

Conversation

kimhanbeom
Copy link
Contributor

  • Added new module 'postgres' to support postgresql.
  • Enhance backup::list/backup::create/backup::restore/backup::recovery function to support postgresql.
  • Added backup::purge_old_backups for apply immediately after num_backups_to_keep is changed.

Closes: #71, #76, #80

@kimhanbeom kimhanbeom force-pushed the david-backup-postgresql branch from 775c1d6 to c1cc81f Compare June 23, 2023 07:01
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #105 (6aa6b1a) into main (a675389) will decrease coverage by 0.44%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   25.87%   25.43%   -0.44%     
==========================================
  Files          59       60       +1     
  Lines       11240    11622     +382     
==========================================
+ Hits         2908     2956      +48     
- Misses       8332     8666     +334     
Impacted Files Coverage Δ
src/lib.rs 44.34% <0.00%> (ø)
src/tables.rs 48.44% <0.00%> (-0.61%) ⬇️
src/backup/postgresql.rs 11.40% <11.40%> (ø)
src/backup.rs 42.17% <16.37%> (-11.33%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

CHANGELOG.md Outdated Show resolved Hide resolved
src/backup/postgresql.rs Show resolved Hide resolved
src/backup/postgresql.rs Outdated Show resolved Hide resolved
src/backup/postgresql.rs Outdated Show resolved Hide resolved
@kimhanbeom kimhanbeom force-pushed the david-backup-postgresql branch from c1cc81f to e93f5d3 Compare June 27, 2023 09:03
@kimhanbeom
Copy link
Contributor Author

해당 사항 수정 완료 했습니다.

@kimhanbeom kimhanbeom requested a review from syncpark June 27, 2023 09:03
CHANGELOG.md Outdated Show resolved Hide resolved
@kimhanbeom kimhanbeom force-pushed the david-backup-postgresql branch from e93f5d3 to ea5c2e5 Compare June 28, 2023 01:20
@kimhanbeom kimhanbeom requested a review from syncpark June 28, 2023 01:29
@syncpark syncpark requested a review from msk June 28, 2023 07:19
@msk msk requested review from minshao and removed request for msk June 28, 2023 23:41
src/backup.rs Outdated Show resolved Hide resolved
src/backup/postgresql.rs Outdated Show resolved Hide resolved
src/backup/postgresql.rs Outdated Show resolved Hide resolved
src/backup/postgresql.rs Outdated Show resolved Hide resolved
src/backup.rs Outdated Show resolved Hide resolved
src/backup.rs Outdated Show resolved Hide resolved
@kimhanbeom kimhanbeom force-pushed the david-backup-postgresql branch from ea5c2e5 to 30c0158 Compare June 29, 2023 06:24
@kimhanbeom kimhanbeom requested review from syncpark, msk and minshao June 29, 2023 06:31
src/backup.rs Outdated Show resolved Hide resolved
src/backup.rs Show resolved Hide resolved
src/backup.rs Outdated Show resolved Hide resolved
src/backup.rs Outdated Show resolved Hide resolved
src/backup.rs Outdated Show resolved Hide resolved
src/backup.rs Outdated Show resolved Hide resolved
src/backup.rs Outdated Show resolved Hide resolved
@kimhanbeom kimhanbeom force-pushed the david-backup-postgresql branch from 30c0158 to 50a163a Compare July 6, 2023 01:52
@kimhanbeom kimhanbeom changed the title Enhance backup logic [WIP] Enhance backup logic Jul 6, 2023
@kimhanbeom kimhanbeom force-pushed the david-backup-postgresql branch from 50a163a to b778e50 Compare July 6, 2023 01:59
@kimhanbeom
Copy link
Contributor Author

@minshao
We are currently working on a simultaneous release to all repositories. We had a meeting with sehkone and decided not to include the improved backup in this release, So I'll change it to WIP until the next version is released.

@kimhanbeom kimhanbeom changed the title [WIP] Enhance backup logic Enhance backup logic Jul 6, 2023
@kimhanbeom kimhanbeom requested a review from minshao July 6, 2023 06:20
- Added new module 'postgres' to support postgresql.
- Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery`
  function to support postgresql.
- Added `backup::purge_old_backups` for apply immediately after
  `num_backups_to_keep` is changed.

Closes: petabi#71, petabi#76, petabi#80
@kimhanbeom kimhanbeom force-pushed the david-backup-postgresql branch from b778e50 to 6aa6b1a Compare July 6, 2023 06:27
@syncpark
Copy link
Contributor

@kimhanbeom rebase 해주세요

@kimhanbeom kimhanbeom changed the title Enhance backup logic [WIP] Enhance backup logic Jan 9, 2024
@msk
Copy link
Contributor

msk commented Feb 27, 2024

Closed per discussion in #206.

@msk msk closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance backup::create to support PostgreSQL backup
4 participants