Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant log message in backup #277

Merged
merged 1 commit into from
May 14, 2024
Merged

Remove redundant log message in backup #277

merged 1 commit into from
May 14, 2024

Conversation

msk
Copy link
Contributor

@msk msk commented May 8, 2024

Errors are now reported through return values only, allowing callers to handle and log errors according to their needs.

This is a part of #215.

Errors are now reported through return values only, allowing callers to
handle and log errors according to their needs.
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 39.14%. Comparing base (a0b02ac) to head (1e77eb4).

Files Patch % Lines
src/backup.rs 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   39.12%   39.14%   +0.01%     
==========================================
  Files          96       96              
  Lines       14673    14656      -17     
==========================================
- Hits         5741     5737       -4     
+ Misses       8932     8919      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@minshao minshao merged commit 0fc671c into main May 14, 2024
10 checks passed
@minshao minshao deleted the backup-log branch May 14, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants