Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helpful logs for some common mistakes #471

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Add helpful logs for some common mistakes #471

merged 1 commit into from
Nov 8, 2023

Conversation

keiko713
Copy link
Contributor

@keiko713 keiko713 commented Nov 8, 2023

Trying to detect some common mistakes of the collector setup and log something useful.

@keiko713 keiko713 requested a review from a team November 8, 2023 03:45
lfittl
lfittl approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@lfittl lfittl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good idea!

@keiko713 keiko713 merged commit 9d8ee71 into main Nov 8, 2023
6 checks passed
@keiko713 keiko713 deleted the better-log-test branch November 8, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msakrejda msakrejda msakrejda approved these changes

@lfittl lfittl lfittl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keiko713 @lfittl @msakrejda