Compact snapshot stats: Fix incorrect counting for current snapshot #481
Conversation
Due to the way the code was written, we would either count the current snapshot, or emit statistics - but even if we emit statistics we still need to increment the snapshot count.
| } | ||
| } | ||
| if len(details) > 0 { | ||
| logger.PrintInfo("Compact snapshots submitted: " + details) |
There was a problem hiding this comment.
Whilst looking at this I also considered whether we should reword this to "Submitted compact snapshots" (to be more consistent with the previous wording, and what's used for full snapshots), but I suspect this was intentionally worded this way in #467 since we're talking about what happened in the last minute (vs what just happened), so I think this is okay to leave worded as is.
cc @msakrejda in case you have any wording thoughts on this message.
for context, right now it is:
Compact snapshots submitted: 5 activity, 3 logs
and I'm wondering if it shouldn't be:
Submitted compact snapshots: 5 activity, 3 logs
There was a problem hiding this comment.
Here is how it looks like currently, so I can see that a previous wording matches to the full snapshot and might be easier to also scan through.
Alternatively, we could also update the "Submitted snapshot successfully" and make it "Full snapshot submitted", though it doesn't look good 🤔
I [default] Compact snapshots submitted: 5 activity, 2 logs
I [default] Compact snapshots submitted: 5 activity, 2 logs
I [default] Submitted snapshot successfully
I [default] Compact snapshots submitted: 5 activity, 2 logs
There was a problem hiding this comment.
If we were to change it, I'm thinking this would be most logical:
I [default] Submitted compact snapshots successfully: 5 activity, 2 logs
I [default] Submitted full snapshot successfully
Let me make a separate PR for this, and we can discuss there.
Due to the way the code was written, we would either count the current snapshot, or emit statistics - but even if we emit statistics we still need to increment the snapshot count.