Allow HTTP clients to be cancelled by passing along context #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces all calls of "http.NewRequest" with "http.NewRequestWithContext", to ensure that the HTTP client stops what its doing immediately when the context gets canceled. The main motivation here is to better handle network connectivity problems to the pganalyze snapshot API, which otherwise make it seem like the collector hangs when trying to cancel a test run with CTRL+C (SIGINT).
seanlinsley
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces all calls of "http.NewRequest" with
"http.NewRequestWithContext", to ensure that the HTTP client stops what its doing immediately when the context gets canceled.
The main motivation here is to better handle network connectivity problems to the pganalyze snapshot API, which otherwise make it seem like the collector hangs when trying to cancel a test run with CTRL+C (SIGINT).