Bump protoc version to 28.2 #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update the setup-protoc version to 3. Note that we still use the forked version to reduce a security risk: #308
seanlinsley
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would have changed generated output/pganalyze_collector/*.pb.go files if there is any changes affecting generation results, but there is not, so it's really not changing anything. Just updating the using protoc version of this repo up to date to make sure that we won't specify anything super ancient.
We also use this protoc within our app to generate *.proto files in Ruby side, and that one was generated using the version later than 3.14.0 (and there was some output difference over there), so this change will make it clear that we generate *.pg.go or *.proto files using 28.2.
I also bumped the
setup-protocGitHub action version with this PR. Historically we weren't using the tag version (and using git SHA) because the tag wasn't existing for the version that was needed (yet, at that time), but there is already a good tag v3 so I updated it to use such thing.