Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect column stats using helper on Postgres < 17 despite warning #619

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

seanlinsley
Copy link
Member

Followup to #610, this makes it so we only fall back to querying pg_stats directly on Postgres 17 and older, since the old function definition will still work until the database server is upgraded.

@seanlinsley seanlinsley requested a review from a team October 18, 2024 22:20
Copy link
Contributor

@keiko713 keiko713 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense, but I don't see the context much. Was this discussed in #610? Or got some feedback somewhere else?

@seanlinsley
Copy link
Member Author

No one's reported it, it was just an improvement I thought up. In the case there would be a permissions error when querying pg_stats directly on old Postgres versions, this will allow the collector to still collect column stats until they upgrade to Postgres 17.

@keiko713
Copy link
Contributor

Ah nice, thanks for the additional context 👍

@seanlinsley seanlinsley merged commit 8b9e229 into main Oct 23, 2024
9 checks passed
@seanlinsley seanlinsley deleted the column_stats_fix branch October 23, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants