TypeScript: PipelineConfig should accept constructors #6999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (delete as applicable)
Describe the changes below:
According to the documentation, the
pipelinefield of theConfigobject is:At some point the type definition of
PipelineConfigwas updated toPhaser.Renderer.WebGL.WebGLPipeline[] | {[key: string]: typeof Phaser.Renderer.WebGL.WebGLPipeline}, allowing it to also take an array, but that's an array of instances, not constructors. I'm not sure if allowing instances was intentional, but either way, it should also allow constructors. This PR preserves the old typing but adds an additional option for constructors.(It looks like passing the constructor works fine, so this is just an omission in the typing.)