fix: remove_custom_button bug (frappe#24199)

* fix: remove_custom_button removes menu item

* fix: correct indentation

* correct formatting

* fix: formatting, add yarn to gitignore

.gitignore

@@ -169,6 +169,7 @@ typings/
 
 # Optional npm cache directory
 .npm
+.yarn
 
 # Optional eslint cache
 .eslintcache

frappe/public/js/frappe/form/form.js

@@ -1456,9 +1456,28 @@ frappe.ui.form.Form = class FrappeForm {
 		this.custom_buttons = {};
 	}
 
-	//Remove specific custom button by button Label
+	// Remove specific custom button by button Label
 	remove_custom_button(label, group) {
 		this.page.remove_inner_button(label, group);
+
+		// Remove actions from menu
+		delete this.custom_buttons[label];
+		let menu_item_label = group ? `${group} > ${label}` : label;
+		let $linkBody = this.page
+			.is_in_group_button_dropdown(
+				this.page.menu,
+				"li > a.grey-link > span",
+				menu_item_label
+			)
+			.parent()
+			.parent();
+
+		if ($linkBody) {
+			// If last button, remove divider too
+			let $divider = $linkBody.next(".dropdown-divider");
+			if ($divider) $divider.remove();
+			$linkBody.remove();
+		}
 	}
 
 	scroll_to_element() {