-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a composer.json to enable support for PIE #82
base: master
Are you sure you want to change the base?
Conversation
e390d98
to
19b4af4
Compare
Hi @bix0r, good to see u're back :) Let's please work on >= PHP 8.1 The rest are EOLed, we shouldn't really spend any efforts there, either we fully support or not fully support. Let's focus our efforts towards the future, I'm happy to have a call about this if needed. |
composer.json
Outdated
"license": "PHP-3.01", | ||
"description": "Apache Solr extension", | ||
"require": { | ||
"php": ">= 7.4,<8.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'>= 8.1, <=8.4'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omars44 I agree that we should aim to sync with PHP on the versions. At least for this new pie stuff. Perhaps not remove support for old versions in code unless we need to.
I will rebase the packaging PR when this is merged.
I am going to move this PR to draft because there is some discussion on the vendor name for extensions living in github.com/php. See Composer issue. |
sure |
See: https://github.com/php/pie/blob/main/docs/extension-maintainers.md