Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store curation information and default nomenclatural code in cookies #260

Merged
merged 11 commits into from
Nov 30, 2022

Conversation

gaurav
Copy link
Member

@gaurav gaurav commented Sep 7, 2022

While writing the tutorial, I realized that users currently need to re-enter their name, e-mail address and ORCID every time they create a new Phyx file. This PR changes that so that those four pieces of information -- as well as the default nomenclatural code -- are stored in the users' browser in cookies for 30 days.

Should be merged after PR #259.

@gaurav gaurav marked this pull request as ready for review October 5, 2022 06:40
@gaurav gaurav requested a review from hlapp October 5, 2022 06:41
Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and is indeed welcome. Now that we're storing cookies in a client's web browser I also think we should at the very least say somewhere that we're doing this. But this can be a separate issue.

Base automatically changed from user-interface-improvements to master October 5, 2022 17:37
@gaurav
Copy link
Member Author

gaurav commented Nov 15, 2022

I've added a checkbox to the "Phyloreference collection" box that looks like this:

Screenshot 2022-11-14 at 10 58 45 PM

As described, the checkbox will either turn on cookies (by creating a COOKIE_ALLOWED cookie on the browser, which allows the getting and setting of cookies to proceed) or -- if unchecked -- delete all Klados cookies, including the COOKIE_ALLOWED cookie. Note that the curation information is in the old format; I'm working on an improved curation information format in phyloref/phyx.js#119.

Here's the text if you would like to suggest improvements:

Click this checkbox if you would like Klados to save your curator information and default nomenclatural code as a browser cookie for the next month, or uncheck it to delete all Klados cookies from your browsers.

@gaurav gaurav requested a review from hlapp November 15, 2022 05:19
Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except I suggested some changes to the label for the checkbox. BTW your phrasing of for the next month is ambiguous (open to various interpretations): for the next 30 days? until the end of the next month? until the end of this month? I chose one interpretation, but you should substitute the correct and unambiguous one.

@gaurav gaurav merged commit d3049cd into master Nov 30, 2022
@gaurav gaurav deleted the store-info-in-cookies branch November 30, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants