Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the Specifier component #333

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Simplify the Specifier component #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
5f94c33
Removed ability of users to edit the specifierLabel.
gaurav Aug 28, 2024
14211ec
Removed apomorphy as a specifier type.
gaurav Aug 28, 2024
1f47bc8
Simplified Specifier.
gaurav Aug 28, 2024
9466993
Added some documentation, made some minor improvements.
gaurav Sep 22, 2024
a0cdb06
Renamed "Verbatim Specifier" to "Specifier label".
gaurav Sep 22, 2024
b3a6e0a
Added a UUID as an example.
gaurav Sep 22, 2024
2246142
Added a better explaining occurrence ID.
gaurav Sep 22, 2024
4598f69
Calculate verbatim label for Taxon and Specimen.
gaurav Sep 22, 2024
d0ab526
Fixed labels.
gaurav Sep 22, 2024
e8c35f1
Simplified some code from wrappedTaxonConcept.
gaurav Sep 22, 2024
0e708f9
Merge branch 'fix-references-to-defaultNomenclaturalCodeURI' into sim…
gaurav Sep 23, 2024
38a11be
Updated and hopefully cleaned up some of this code.
gaurav Sep 23, 2024
94eb6ce
Some tweaks and documentation to taxon name fields.
gaurav Sep 25, 2024
84cfb3a
Got rid of some computed values that are unnecessary.
gaurav Sep 25, 2024
fed6739
Added external reference to specifierLabel.
gaurav Sep 25, 2024
c9e32be
Improve documentation.
gaurav Sep 25, 2024
dc41f81
Top-level documentation on the two key methods.
gaurav Sep 25, 2024
4e64360
Cleaned up and improved loadSpecifier().
gaurav Sep 25, 2024
def7d79
Added watches to make sure that the specifier updates properly.
gaurav Sep 25, 2024
3b87f5b
Removed redundant CSS command.
gaurav Nov 4, 2024
6079db1
Make sure the Specifier component is reset in between loads.
gaurav Nov 4, 2024
33aa5e0
Some (possibly useless) tweaks.
gaurav Dec 18, 2024
b105a43
Removed unnecessary index.
gaurav Jan 13, 2025
112ed15
We need to update phyloref type when the specifier composition changes.
gaurav Jan 13, 2025
5f6ae48
Fixed the self-triggering event.
gaurav Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/phyloref/PhylorefView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ export default {
},
computedPhylorefType() {
// Return the type of phyloreference based on internal/external specifier structure.
return this.$store.getters.getPhylorefType(this.selectedPhyloref);
return this.$store.getters.getPhylorefTypeAsString(this.selectedPhyloref);
},
phylorefURI() {
// Get the base URI of this phyloreference.
Expand Down
4 changes: 2 additions & 2 deletions src/components/phyx/PhyxView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
{{ getPhylorefLabel(phyloref) }}
</a>
</td>
<td>{{ $store.getters.getPhylorefType(phyloref) }}</td>
<td>{{ $store.getters.getPhylorefTypeAsString(phyloref) }}</td>
<td>{{ (phyloref.internalSpecifiers || []).length }}</td>
<td>{{ (phyloref.externalSpecifiers || []).length }}</td>
<td v-for="(phylogeny, phylogenyIndex) of phylogenies">
Expand Down Expand Up @@ -498,7 +498,7 @@ export default {
return [
this.$store.getters.getPhylorefId(phyloref),
wrappedPhyloref.label,
this.$store.getters.getPhylorefType(phyloref),
this.$store.getters.getPhylorefTypeAsString(phyloref),
// Write out the clade definition.
phyloref.definition || "",
// Write out the internal specifier labels
Expand Down
Loading