-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fields for storing curator information #119
Comments
@matentzn or @cmungall if either of you have any additional pointers or comments on where to look for ontology term curator attribution recommended practices for OBO, that'd be useful. (FYI, in the OG issue documentation above, a phyloreference becomes a (defined) class in an ontology, so it's about documenting curators at the level of terms/classes.) |
Here is a nice issue that illustrates the chaos: information-artifact-ontology/ontology-metadata#60 If you cover all properties mentioned by this thread you are probably in a good place. We are pushing hard (against plenty resistance) to standardise on dc:creator is found as well, always check the dcterms vs dc elements variants of IRIs if you want everything. My two cents: |
@balhoff pointed out that Dublin Core recommends that creators and contributors are identified by URI if feasible, and suggested the following approach: :phyloref0 dc:contributor <http://orcid.org/0000-0003-0587-0454> .
<http://orcid.org/0000-0003-0587-0454> foaf:name "Gaurav Vaidya" This can be represented in JSON-LD in a pretty compact way by adding two additional terms to our JSON-LD context: {
"@context": {
"contributors": {
"@id": "http://purl.org/dc/terms/contributor",
"@container": "@set"
},
"name": "http://xmlns.com/foaf/0.1/name"
},
"contributors": [{
"@id": "http://orcid.org/0000-0003-0587-0454",
"name": "Gaurav Vaidya"
}, {
"@id": "https://orcid.org/0000-0001-9107-0714",
"name": "Hilmar Lapp"
}]
} A contributor without an ORCID could either be represented by a blank node with a |
Sounds like a good plan to me, and I agree, the |
This PR adds curator information to the Phyx file as "contributors" with ORCIDs and names as described in #119 (comment). Closes #119. I've also added a `.java-version` file to indicate that Java 15 should be used to run JPhyloRef, and pinned newick-js to v1.1.1 to avoid a bug (keesey/newick-js#4).
This is needed by Klados, and should only include the curator name and ORCID. Looking at some other ontologies, there are a number of ways in which this information is recorded:
dc:contributor
field (e.g. https://github.com/cmungall in http://purl.obolibrary.org/obo/UBERON_0000020)dc:contributor
to the ontology rather than to individual terms as documented by the Cell Ontology, which also proposed usingdc:creator
to record per-term creator information.I propose we add a
contributors
field as a list of strings to phyloreferences and map it todc:contributor
in JSON-LD. We would recommend that contributors should be recorded as a string in the formatName (orcid:1111-2222-3333-4444)
.The text was updated successfully, but these errors were encountered: