Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Falcon asgi template #1139

Merged
merged 4 commits into from
Jan 26, 2025
Merged

add Falcon asgi template #1139

merged 4 commits into from
Jan 26, 2025

Conversation

sinisaos
Copy link
Member

Adding Falcon asgi template.

@sinisaos sinisaos added the enhancement New feature or request label Jan 14, 2025
@dantownsend
Copy link
Member

This one has merge conflicts now because I merged the Quart PR.

@sinisaos
Copy link
Member Author

Done.

@dantownsend dantownsend self-requested a review January 26, 2025 12:56
dantownsend
dantownsend approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@dantownsend dantownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for this - are you able to merge it in yourself once the CI has finished?

@sinisaos
Copy link
Member Author

I've already started updating the branch. It should be over quickly.

@sinisaos
Copy link
Member Author

sinisaos commented Jan 26, 2025 •
edited
Loading

Done, you can merge it. Thanks.

@sinisaos sinisaos merged commit 55c2dbc into piccolo-orm:master Jan 26, 2025
46 checks passed
@sinisaos sinisaos deleted the falcon_asgi_template branch January 26, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantownsend dantownsend dantownsend approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sinisaos @dantownsend