Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pip requirements, add github actions #54

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

SallyDa
Copy link
Collaborator

@SallyDa SallyDa commented Oct 25, 2024

Automated formatting with black.
Automated running of tests with pytest (including installing dependencies with pip).

We can discuss whether we want to use black or something else, whether we want these formatting changes to be committed automatically (as done here), and whether we want to use pip or poetry for dependencies (didn't get the tests running automatically using the poetry environment, but could spend more time looking into this). We can also discuss if we want anything else automated, and if we want these checks/commits to apply to other branches than main.

@SallyDa SallyDa marked this pull request as draft October 25, 2024 07:48
@SallyDa SallyDa marked this pull request as ready for review October 25, 2024 07:55
@SallyDa SallyDa requested a review from JakobBD October 25, 2024 08:17
@SallyDa SallyDa force-pushed the main_actions branch 2 times, most recently from 2e0a376 to 76797a0 Compare October 30, 2024 14:55
tests/test_helpers.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@JakobBD JakobBD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with merging this right away and doing the re-formatting in a separate PR

@JakobBD JakobBD merged commit a001af8 into pik-piam:main Nov 26, 2024
2 checks passed
@SallyDa SallyDa deleted the main_actions branch November 26, 2024 13:41
@SallyDa SallyDa mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants