Flexible datainput #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still needs tests, testing, adapted examples. |
for more information, see https://pre-commit.ci
|
Can we keep the current very flexible DataReader as is please? And then make this one a child class with an init that takes the DimensionReader and ParameterReader, and read_parameters that then calls self.parameter_reader.read_all? This way you also won't need to update the examples. |
|
Ah yes, that should work, nice suggestion. I will try it out. There's a few other things I'm going to ask your opinion/input on once I have a working version. |
|
Perfect, let me know when you have finished/tested :) |
This was referenced Dec 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.