Remove redundant check and call compareScenarios also for runs that converged but had INFES #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run compareScenarios also for runs that have "converged (had INFES)", not only for runs that "converged".
orichters
reviewed
May 22, 2024
| message("Skipping ", i, " and changed back to ", normalizePath(".")) | ||
| next | ||
| } | ||
| load("config.Rdata") | ||
| sameRuns <- gRS %>% filter(.data$Conv %in% c("converged", "converged (had INFES)"), # runs have to be converged |
There was a problem hiding this comment.
I think a cs2 is useful even if the run did not converge, specifically because one would want to look at why it didn't.
There was a problem hiding this comment.
I'm not sure which runs you are interested in. I assume you mean the ones that are feasible but didn't make it to 100 iterations (status "not_converged"), right? Because runs that are infeasible don't write a mif file, so no cs2 could be run.
There was a problem hiding this comment.
Exactly, those with status not_converged
orichters
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.